fix: remove intrusive error notification for unresolvable Python paths (Fixes microsoft#1283)

Author: karthiknadig

src/common/pickers/environments.ts

@@ -1,4 +1,4 @@
-import { ProgressLocation, QuickInputButtons, QuickPickItem, QuickPickItemKind, ThemeIcon, Uri } from 'vscode';
+import { ProgressLocation, QuickInputButtons, QuickPickItem, QuickPickItemKind, ThemeIcon, Uri, l10n } from 'vscode';
 import { CreateEnvironmentOptions, IconPath, PythonEnvironment, PythonProject } from '../../api';
 import { InternalEnvironmentManager } from '../../internal.api';
 import { Common, Interpreter, Pickers } from '../localize';
@@ -7,7 +7,13 @@ import { EventNames } from '../telemetry/constants';
 import { sendTelemetryEvent } from '../telemetry/sender';
 import { isWindows } from '../utils/platformUtils';
 import { handlePythonPath } from '../utils/pythonPath';
-import { showOpenDialog, showQuickPick, showQuickPickWithButtons, withProgress } from '../window.apis';
+import {
+    showErrorMessage,
+    showOpenDialog,
+    showQuickPick,
+    showQuickPickWithButtons,
+    withProgress,
+} from '../window.apis';
 import { pickEnvironmentManager } from './managers';
 
 type QuickPickIcon =
@@ -66,6 +72,11 @@ async function browseForPython(
             return env;
         },
     );
+
+    if (!environment) {
+        showErrorMessage(l10n.t('Selected file is not a valid Python interpreter: {0}', uri.fsPath));
+    }
+
     return environment;
 }
 

src/common/utils/pythonPath.ts

@@ -1,9 +1,8 @@
-import { Uri, Progress, CancellationToken } from 'vscode';
+import { CancellationToken, Progress, Uri } from 'vscode';
 import { PythonEnvironment } from '../../api';
 import { InternalEnvironmentManager } from '../../internal.api';
-import { traceVerbose, traceError } from '../logging';
 import { PYTHON_EXTENSION_ID } from '../constants';
-import { showErrorMessage } from '../window.apis';
+import { traceVerbose, traceWarn } from '../logging';
 
 const priorityOrder = [
     `${PYTHON_EXTENSION_ID}:pyenv`,
@@ -74,7 +73,6 @@ export async function handlePythonPath(
         }
     }
 
-    traceError(`Unable to handle ${interpreterUri.fsPath}`);
-    showErrorMessage(`Unable to handle ${interpreterUri.fsPath}`);
+    traceWarn(`Unable to handle ${interpreterUri.fsPath}`);
     return undefined;
 }

src/features/envCommands.ts

@@ -1,6 +1,15 @@
 import * as fs from 'fs-extra';
 import * as path from 'path';
-import { ProgressLocation, QuickInputButtons, TaskExecution, TaskRevealKind, Terminal, Uri, workspace } from 'vscode';
+import {
+    ProgressLocation,
+    QuickInputButtons,
+    TaskExecution,
+    TaskRevealKind,
+    Terminal,
+    Uri,
+    l10n,
+    workspace,
+} from 'vscode';
 import {
     CreateEnvironmentOptions,
     PythonEnvironment,
@@ -93,6 +102,10 @@ async function browseAndResolveInterpreter(
         },
     );
 
+    if (!environment) {
+        showErrorMessage(l10n.t('Selected file is not a valid Python interpreter: {0}', interpreterUri.fsPath));
+    }
+
     return environment;
 }