fix: return empty string for empty command arrays in getShellCommandAsString

Author: karthiknadig

src/features/terminal/shells/common/shellUtils.ts

@@ -24,6 +24,11 @@ const shellDelimiterByShell = new Map<string, string>([
 ]);
 
 export function getShellCommandAsString(shell: string, command: PythonCommandRunConfiguration[]): string {
+    // Return empty string for empty command arrays (e.g., when activation is intentionally skipped)
+    if (command.length === 0) {
+        return '';
+    }
+
     const delimiter = shellDelimiterByShell.get(shell) ?? defaultShellDelimiter;
     const parts = [];
     for (const cmd of command) {

src/test/features/terminal/shells/common/shellUtils.unit.test.ts

@@ -99,9 +99,7 @@ suite('Shell Utils', () => {
     });
 
     suite('getShellCommandAsString', () => {
-        const sampleCommand: PythonCommandRunConfiguration[] = [
-            { executable: 'source', args: ['/path/to/activate'] },
-        ];
+        const sampleCommand: PythonCommandRunConfiguration[] = [{ executable: 'source', args: ['/path/to/activate'] }];
 
         suite('leading space for history ignore', () => {
             test('should add leading space for bash commands', () => {
@@ -184,5 +182,27 @@ suite('Shell Utils', () => {
                 assert.ok(!result.startsWith(' '), 'Fish command should not start with a leading space');
             });
         });
+
+        suite('empty command handling', () => {
+            test('should return empty string for empty command array (bash)', () => {
+                const result = getShellCommandAsString(ShellConstants.BASH, []);
+                assert.strictEqual(result, '', 'Empty command array should return empty string');
+            });
+
+            test('should return empty string for empty command array (gitbash)', () => {
+                const result = getShellCommandAsString(ShellConstants.GITBASH, []);
+                assert.strictEqual(result, '', 'Empty command array should return empty string');
+            });
+
+            test('should return empty string for empty command array (pwsh)', () => {
+                const result = getShellCommandAsString(ShellConstants.PWSH, []);
+                assert.strictEqual(result, '', 'Empty command array should return empty string');
+            });
+
+            test('should return empty string for empty command array (cmd)', () => {
+                const result = getShellCommandAsString(ShellConstants.CMD, []);
+                assert.strictEqual(result, '', 'Empty command array should return empty string');
+            });
+        });
     });
 });