Skip to content

Commit b4b31eb

Browse files
committed
fix: ensure that we use new extension when available for terminal creation
1 parent 8478bf0 commit b4b31eb

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

src/client/common/application/commands.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ interface ICommandNameWithoutArgumentTypeMapping {
4141
[Commands.CreateNewFile]: [];
4242
[Commands.ReportIssue]: [];
4343
[LSCommands.RestartLS]: [];
44+
['python-envs.createTerminal']: [];
4445
}
4546

4647
export type AllCommands = keyof ICommandNameArgumentTypeMapping;

src/client/providers/terminalProvider.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,13 @@ export class TerminalProvider implements Disposable {
6060

6161
@captureTelemetry(EventName.TERMINAL_CREATE, { triggeredBy: 'commandpalette' })
6262
private async onCreateTerminal() {
63-
const terminalService = this.serviceContainer.get<ITerminalServiceFactory>(ITerminalServiceFactory);
6463
const activeResource = this.activeResourceService.getActiveResource();
64+
if (useEnvExtension()) {
65+
const commandManager = this.serviceContainer.get<ICommandManager>(ICommandManager);
66+
await commandManager.executeCommand('python-envs.createTerminal', activeResource);
67+
}
68+
69+
const terminalService = this.serviceContainer.get<ITerminalServiceFactory>(ITerminalServiceFactory);
6570
await terminalService.createTerminalService(activeResource, 'Python').show(false);
6671
}
6772
}

0 commit comments

Comments
 (0)