fix(zig): replace ** to @splat()

kassane · kassane · commit 1c7150dceddf · 2026-05-07T13:55:13.000-03:00
updated toolchains
diff --git a/build.zig b/build.zig
@@ -2850,7 +2850,7 @@ fn addSnesExe(
 
     // Build ROM header title: pad/truncate to exactly 21 ASCII bytes.
     const raw_title = cfg.title orelse if (cfg.hirom) "ZIG SNES HIROM" else "ZIG SNES HELLO";
-    var title_buf: [21]u8 = .{' '} ** 21;
+    var title_buf: [21]u8 = @splat(' ');
     @memcpy(title_buf[0..@min(raw_title.len, 21)], raw_title[0..@min(raw_title.len, 21)]);
     const map_mode: u8 = if (cfg.hirom) 0x21 else if (cfg.fastrom) 0x30 else 0x20;
 
diff --git a/nes/cnrom-hello/cnrom-hello.zig b/nes/cnrom-hello/cnrom-hello.zig
@@ -12,7 +12,7 @@ pub export fn main() callconv(.c) void {
     // Select CHR bank 0 (Alpha.chr) before enabling rendering.
     mapper.set_chr_bank(0);
     // Blue background: NES palette 0x11 (light blue), white text on colour 3.
-    const bg_pal: [16]u8 = .{ 0x11, 0x00, 0x10, 0x30 } ++ .{0x00} ** 12;
+    const bg_pal: [16]u8 = .{ 0x11, 0x00, 0x10, 0x30, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
     neslib.pal_bright(4);
     neslib.pal_bg(&bg_pal);
     neslib.vram_adr(neslib.NTADR_A(4, 14));
diff --git a/nes/gtrom-color-cycle/gtrom-color-cycle.zig b/nes/gtrom-color-cycle/gtrom-color-cycle.zig
@@ -15,7 +15,8 @@ pub export fn main() callconv(.c) void {
     mapper.set_nt_bank(0);
     _ = mapper.set_mapper_green_led(true);
     _ = mapper.set_mapper_red_led(false);
-    neslib.pal_bg(&(.{0x0f} ** 16));
+    const pal: [16]u8 = @splat(0x0f);
+    neslib.pal_bg(&pal);
     neslib.ppu_on_bg();
 
     var color: u8 = 0;
diff --git a/nes/gtrom-hello/gtrom-hello.zig b/nes/gtrom-hello/gtrom-hello.zig
@@ -17,7 +17,7 @@ pub export fn main() callconv(.c) void {
     mapper.set_nt_bank(0);
     // Light the green LED on the cartridge PCB.
     _ = mapper.set_mapper_green_led(true);
-    const bg_pal: [16]u8 = .{ 0x19, 0x19, 0x29, 0x39 } ++ .{0x00} ** 12;
+    const bg_pal: [16]u8 = .{ 0x19, 0x19, 0x29, 0x39, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
     neslib.pal_bright(4);
     neslib.pal_bg(&bg_pal);
     neslib.ppu_on_all();
diff --git a/nes/mmc1-hello/mmc1-hello.zig b/nes/mmc1-hello/mmc1-hello.zig
@@ -13,7 +13,7 @@ pub export fn main() callconv(.c) void {
     // Initialise MMC1: select PRG bank 0 and set vertical mirroring.
     mapper.set_prg_bank(0);
     mapper.set_mirroring(mapper.MIRROR_VERTICAL);
-    const bg_pal: [16]u8 = .{ 0x1A, 0x1A, 0x2A, 0x3A } ++ .{0x00} ** 12;
+    const bg_pal: [16]u8 = .{ 0x1A, 0x1A, 0x2A, 0x3A, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
     neslib.pal_bright(4);
     neslib.pal_bg(&bg_pal);
     neslib.ppu_on_all();
diff --git a/nes/mmc3-hello/mmc3-hello.zig b/nes/mmc3-hello/mmc3-hello.zig
@@ -14,7 +14,7 @@ pub export fn main() callconv(.c) void {
     mapper.set_prg_8000(0);
     mapper.set_prg_a000(1);
     mapper.set_mirroring(mapper.MIRROR_VERTICAL);
-    const bg_pal: [16]u8 = .{ 0x1C, 0x1C, 0x2C, 0x3C } ++ .{0x00} ** 12;
+    const bg_pal: [16]u8 = .{ 0x1C, 0x1C, 0x2C, 0x3C, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
     neslib.pal_bright(4);
     neslib.pal_bg(&bg_pal);
     neslib.ppu_on_all();
diff --git a/nes/nesdoug/color-cycle/color-cycle.zig b/nes/nesdoug/color-cycle/color-cycle.zig
@@ -6,7 +6,8 @@ const neslib = @import("neslib");
 
 pub export fn main() callconv(.c) void {
     neslib.ppu_off();
-    neslib.pal_bg(&(.{0x0f} ** 16));
+    const pal: [16]u8 = @splat(0x0f);
+    neslib.pal_bg(&pal);
     neslib.ppu_on_bg();
 
     var color: u8 = 0;
diff --git a/nes/nesdoug/full-game/full_game.zig b/nes/nesdoug/full-game/full_game.zig
@@ -666,20 +666,20 @@ var death: u8 = 0;
 var map_loaded: u8 = 0;
 var enemy_frames: u8 = 0;
 
-var coin_x: [MAX_COINS]u8 = [_]u8{0} ** MAX_COINS;
-var coin_y: [MAX_COINS]u8 = [_]u8{TURN_OFF} ** MAX_COINS;
-var coin_active: [MAX_COINS]u8 = [_]u8{0} ** MAX_COINS;
-var coin_room: [MAX_COINS]u8 = [_]u8{0} ** MAX_COINS;
-var coin_actual_x: [MAX_COINS]u8 = [_]u8{0} ** MAX_COINS;
-var coin_type: [MAX_COINS]u8 = [_]u8{0} ** MAX_COINS;
-
-var enemy_x: [MAX_ENEMY]u8 = [_]u8{0} ** MAX_ENEMY;
-var enemy_y: [MAX_ENEMY]u8 = [_]u8{TURN_OFF} ** MAX_ENEMY;
-var enemy_active: [MAX_ENEMY]u8 = [_]u8{0} ** MAX_ENEMY;
-var enemy_room: [MAX_ENEMY]u8 = [_]u8{0} ** MAX_ENEMY;
-var enemy_actual_x: [MAX_ENEMY]u8 = [_]u8{0} ** MAX_ENEMY;
-var enemy_type: [MAX_ENEMY]u8 = [_]u8{0} ** MAX_ENEMY;
-var enemy_anim: [MAX_ENEMY]?*const anyopaque = [_]?*const anyopaque{null} ** MAX_ENEMY;
+var coin_x: [MAX_COINS]u8 = @splat(0);
+var coin_y: [MAX_COINS]u8 = @splat(TURN_OFF);
+var coin_active: [MAX_COINS]u8 = @splat(0);
+var coin_room: [MAX_COINS]u8 = @splat(0);
+var coin_actual_x: [MAX_COINS]u8 = @splat(0);
+var coin_type: [MAX_COINS]u8 = @splat(0);
+
+var enemy_x: [MAX_ENEMY]u8 = @splat(0);
+var enemy_y: [MAX_ENEMY]u8 = @splat(TURN_OFF);
+var enemy_active: [MAX_ENEMY]u8 = @splat(0);
+var enemy_room: [MAX_ENEMY]u8 = @splat(0);
+var enemy_actual_x: [MAX_ENEMY]u8 = @splat(0);
+var enemy_type: [MAX_ENEMY]u8 = @splat(0);
+var enemy_anim: [MAX_ENEMY]?*const anyopaque = @splat(null);
 
 // Persistent loop state
 var short_jump_count: u8 = 0;
diff --git a/nes/nesdoug/hello1/hello1.zig b/nes/nesdoug/hello1/hello1.zig
@@ -6,7 +6,7 @@ const neslib = @import("neslib");
 
 /// One full BG palette (4 sub-palettes × 4 colours = 16 bytes).
 /// Sub-palette 0: black background, three greys.
-const bg_palette: [16]u8 = .{ 0x0f, 0x00, 0x10, 0x30 } ++ .{0x00} ** 12;
+const bg_palette: [16]u8 = .{ 0x0f, 0x00, 0x10, 0x30, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
 
 pub export fn main() callconv(.c) void {
     neslib.ppu_off();
diff --git a/nes/nesdoug/hello2/hello2.zig b/nes/nesdoug/hello2/hello2.zig
@@ -4,7 +4,7 @@
 pub const panic = @import("mos_panic");
 const neslib = @import("neslib");
 
-const bg_palette: [16]u8 = .{ 0x0f, 0x00, 0x10, 0x30 } ++ .{0x00} ** 12;
+const bg_palette: [16]u8 = .{ 0x0f, 0x00, 0x10, 0x30, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
 
 pub export fn main() callconv(.c) void {
     // Sequential VRAM packet: writes "HELLO WORLD!" horizontally at tile (10, 14).
diff --git a/nes/nesdoug/hello3/hello3.zig b/nes/nesdoug/hello3/hello3.zig
@@ -5,7 +5,7 @@ pub const panic = @import("mos_panic");
 const neslib = @import("neslib");
 const nesdoug = @import("nesdoug");
 
-const bg_palette: [16]u8 = .{ 0x0f, 0x00, 0x10, 0x30 } ++ .{0x00} ** 12;
+const bg_palette: [16]u8 = .{ 0x0f, 0x00, 0x10, 0x30, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
 const message: [12]u8 = .{ 'H', 'E', 'L', 'L', 'O', ' ', 'W', 'O', 'R', 'L', 'D', '!' };
 
 pub export fn main() callconv(.c) void {
diff --git a/nes/nesdoug/megablast/megablast.zig b/nes/nesdoug/megablast/megablast.zig
@@ -27,7 +27,7 @@ const sp_palette: [16]u8 = .{
     0x0F, 0x38, 0x28, 0x18,
     0x0F, 0x12, 0x22, 0x32,
 };
-const mountain_tiles: [32]u8 = .{ 1, 2, 3, 4 } ** 8;
+const mountain_tiles: [32]u8 = .{ 1, 2, 3, 4, 1, 2, 3, 4, 1, 2, 3, 4, 1, 2, 3, 4, 1, 2, 3, 4, 1, 2, 3, 4, 1, 2, 3, 4, 1, 2, 3, 4 };
 
 // Enemy source data (9 bytes): start_pat, end_pat, sprite_type, dx, dy, score, width, height, attr
 // sprite_type: 1 = one sprite, any other value = four sprites
@@ -48,8 +48,8 @@ var shake: u8 = 0;
 var enemy_cooldown: u8 = 0;
 var enemy_count: u8 = 0;
 var display_level: u8 = 0;
-var enemy_data: [100]u8 = .{0} ** 100; // 10 enemies × 10 bytes
-var star_addrs: [10]u16 = .{0} ** 10;
+var enemy_data: [100]u8 = @splat(0); // 10 enemies × 10 bytes
+var star_addrs: [10]u16 = @splat(0);
 
 // Palette cycle state (bg palette 0, colors 1 and 2)
 var pal1: u8 = bg_palette[1];
@@ -104,8 +104,8 @@ fn queueHighScore() void {
 }
 
 fn queueLives() void {
-    var row1: [16]u8 = .{0} ** 16;
-    var row2: [16]u8 = .{0} ** 16;
+    var row1: [16]u8 = @splat(0);
+    var row2: [16]u8 = @splat(0);
     const n: u8 = if (lives > 8) 8 else lives;
     var i: u8 = 0;
     while (i < n) : (i += 1) {
@@ -128,7 +128,7 @@ fn queueLevelText() void {
 }
 
 fn queueLevelErase() void {
-    const blank: [14]u8 = .{0} ** 14;
+    const blank: [14]u8 = @splat(0);
     nesdoug.multi_vram_buffer_horz(&blank, blank.len, ntaddr(14, 9));
 }
 
@@ -499,7 +499,7 @@ fn displayTitleScreen() void {
     const press = "PRESS FIRE TO BEGIN";
     neslib.vram_adr(neslib.NTADR_A(6, 20));
     neslib.vram_write(press, press.len);
-    const attr_row: [8]u8 = .{0x05} ** 8;
+    const attr_row: [8]u8 = @splat(0x05);
     neslib.vram_adr(0x23C0 + 8);
     neslib.vram_write(&attr_row, attr_row.len);
     neslib.ppu_on_all();
diff --git a/nes/unrom-512-hello/unrom-512-hello.zig b/nes/unrom-512-hello/unrom-512-hello.zig
@@ -15,7 +15,7 @@ pub export fn main() callconv(.c) void {
     _ = mapper.set_prg_bank(0);
     // CHR bank 0 is already selected at reset; explicit for clarity.
     mapper.set_chr_bank(0);
-    const bg_pal: [16]u8 = .{ 0x1A, 0x1A, 0x27, 0x30 } ++ .{0x00} ** 12;
+    const bg_pal: [16]u8 = .{ 0x1A, 0x1A, 0x27, 0x30, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
     neslib.pal_bright(4);
     neslib.pal_bg(&bg_pal);
     neslib.ppu_on_all();
diff --git a/nes/unrom-color-cycle/unrom-color-cycle.zig b/nes/unrom-color-cycle/unrom-color-cycle.zig
@@ -10,7 +10,8 @@ const mapper = @import("mapper");
 pub export fn main() callconv(.c) void {
     neslib.ppu_off();
     mapper.set_prg_bank(0);
-    neslib.pal_bg(&(.{0x0f} ** 16));
+    const pal: [16]u8 = @splat(0x0f);
+    neslib.pal_bg(&pal);
     neslib.ppu_on_bg();
 
     var color: u8 = 0;
diff --git a/nes/unrom-hello/unrom-hello.zig b/nes/unrom-hello/unrom-hello.zig
@@ -12,7 +12,7 @@ pub export fn main() callconv(.c) void {
     neslib.ppu_off();
     // Switch to PRG bank 0 explicitly before enabling rendering.
     mapper.set_prg_bank(0);
-    const bg_pal: [16]u8 = .{ 0x16, 0x16, 0x27, 0x30 } ++ .{0x00} ** 12;
+    const bg_pal: [16]u8 = .{ 0x16, 0x16, 0x27, 0x30, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
     neslib.pal_bright(4);
     neslib.pal_bg(&bg_pal);
     neslib.ppu_on_all();
diff --git a/snes/pi-snes/pi-snes.zig b/snes/pi-snes/pi-snes.zig
@@ -33,7 +33,7 @@ const MAX_DIGITS: usize = 900;
 
 var A: [A_LEN]u8 = undefined;
 // WRAM buffer: all computed digits as ASCII.
-var pi_digits: [MAX_DIGITS]u8 = .{0} ** MAX_DIGITS;
+var pi_digits: [MAX_DIGITS]u8 = @splat(0);
 var pi_count: u16 = 0;
 // Tracks how many digits have been written to VRAM so far.
 var render_head: u16 = 0;
diff --git a/tools/bininfo.zig b/tools/bininfo.zig
@@ -160,7 +160,7 @@ fn dumpDebugInfo(
     };
     defer di.deinit(gpa);
 
-    out.print("  -- debug_info DIEs " ++ "-" ** 35 ++ "\n", .{}) catch {};
+    out.print("  -- debug_info DIEs " ++ "-----------------------------------" ++ "\n", .{}) catch {};
 
     for (di.compile_unit_list.items) |*cu| {
         const cu_name = cu.die.getAttrString(
@@ -211,7 +211,7 @@ fn dumpDebugInfo(
 
 // Parse .debug_line and display source file tables.
 fn dumpDebugLine(out: anytype, debug_line: []const u8) void {
-    out.print("  -- debug_line file tables " ++ "-" ** 27 ++ "\n", .{}) catch {};
+    out.print("  -- debug_line file tables " ++ "---------------------------" ++ "\n", .{}) catch {};
     var pos: usize = 0;
     var ltu: u32 = 0;
     while (pos + 10 <= debug_line.len) {
@@ -351,7 +351,7 @@ fn checkElf(out: anytype, gpa: std.mem.Allocator, path: []const u8, data: []cons
 
     // ── Section table (all sections, like llvm-readelf -S) ───────────────────
     if (opts.sections) {
-        out.print("  -- Sections " ++ "-" ** 42 ++ "\n", .{}) catch {};
+        out.print("  -- Sections " ++ "------------------------------------------" ++ "\n", .{}) catch {};
         out.print("  {s:<22} {s:<10} {s:>8}  {s}\n", .{ "Name", "Type", "Size", "Flags/VMA" }) catch {};
         for (0..e_shnum) |i| {
             const sh = readVal(elf.Elf32_Shdr, data, @as(usize, e_shoff) + i * e_shentsize);
@@ -426,7 +426,7 @@ fn checkElf(out: anytype, gpa: std.mem.Allocator, path: []const u8, data: []cons
 
         // Build a per-symbol section cache for type resolution.
         // For each symbol we need its section's sh_type and sh_flags.
-        out.print("  -- Symbols (nm) " ++ "-" ** 38 ++ "\n", .{}) catch {};
+        out.print("  -- Symbols (nm) " ++ "--------------------------------------" ++ "\n", .{}) catch {};
 
         const sym_base = symtab_off;
         const show_locals = sym_count < 64; // show locals only for small objects
@@ -479,8 +479,8 @@ fn checkElf(out: anytype, gpa: std.mem.Allocator, path: []const u8, data: []cons
             ".debug_frame",
             ".eh_frame",
         };
-        var dwarf_offsets = [_]u32{0} ** dwarf_names.len;
-        var dwarf_sizes = [_]u32{0} ** dwarf_names.len;
+        var dwarf_offsets: [dwarf_names.len]u32 = @splat(0);
+        var dwarf_sizes: [dwarf_names.len]u32 = @splat(0);
 
         for (0..e_shnum) |i| {
             const sh = readVal(elf.Elf32_Shdr, data, @as(usize, e_shoff) + i * e_shentsize);
@@ -525,7 +525,7 @@ fn checkElf(out: anytype, gpa: std.mem.Allocator, path: []const u8, data: []cons
                 }
             }
 
-            out.print("  -- DWARF " ++ "-" ** 45 ++ "\n", .{}) catch {};
+            out.print("  -- DWARF " ++ "---------------------------------------------" ++ "\n", .{}) catch {};
             if (dwarf_ver > 0)
                 out.print("  version=DWARFv{d}  compile-units={d}\n", .{ dwarf_ver, cu_count }) catch {};
 
@@ -1043,7 +1043,7 @@ fn op(m: *const [3]u8, mode: OpcodeMode) OpcodeInfo {
 
 const opcode_table: [256]OpcodeInfo = blk: {
     const M = OpcodeMode;
-    var t = [_]OpcodeInfo{.{ .mnem = "???\x00".*, .mode = .imp }} ** 256;
+    var t: [256]OpcodeInfo = @splat(.{ .mnem = "???\x00".*, .mode = .imp });
     t[0x00] = op("BRK", .imp);
     t[0x01] = op("ORA", .indx);
     t[0x05] = op("ORA", .zp);
@@ -1459,7 +1459,7 @@ pub fn main(init: std.process.Init) !void {
             if (!checkFile(stdout, alloc, arg, data, opts)) all_ok = false;
 
             if (opts.xxd) {
-                stdout.print("  -- xxd " ++ "-" ** 47 ++ "\n", .{}) catch {};
+                stdout.print("  -- xxd " ++ "-----------------------------------------------" ++ "\n", .{}) catch {};
                 xxdDump(stdout, data, opts.xxd_limit);
             }
             if (opts.disasm) {
@@ -1468,7 +1468,7 @@ pub fn main(init: std.process.Init) !void {
                     std.ascii.eqlIgnoreCase(std.fs.path.extension(arg), ".prg");
                 const load_addr: u16 = if (is_prg) readU16Le(data, 0) else 0;
                 const payload: []const u8 = if (is_prg) data[2..] else data;
-                stdout.print("  -- disasm (6502) load=${x:0>4} " ++ "-" ** 24 ++ "\n", .{load_addr}) catch {};
+                stdout.print("  -- disasm (6502) load=${x:0>4} " ++ "------------------------" ++ "\n", .{load_addr}) catch {};
                 disasm6502(stdout, payload, load_addr);
             }
             stdout_fw.flush() catch {};
diff --git a/tools/romtool.zig b/tools/romtool.zig
@@ -156,7 +156,7 @@ fn op(m: *const [3]u8, mode: OpcodeMode) OpcodeInfo {
 
 const opcode_table: [256]OpcodeInfo = blk: {
     const M = OpcodeMode;
-    var t = [_]OpcodeInfo{.{ .mnem = "???\x00".*, .mode = .imp }} ** 256;
+    var t: [256]OpcodeInfo = @splat(.{ .mnem = "???\x00".*, .mode = .imp });
     t[0x00] = op("BRK", .imp);
     t[0x01] = op("ORA", .indx);
     t[0x05] = op("ORA", .zp);
@@ -1390,7 +1390,7 @@ fn cmdPackNes(alloc: std.mem.Allocator, io: std.Io, args: anytype) !void {
     flags7 |= @as(u8, @truncate((mapper_num >> 4) & 0x0F)) << 4;
     if (emit_nes2) flags7 |= 0x08;
 
-    var header = [_]u8{0} ** 16;
+    var header: [16]u8 = @splat(0);
     header[0] = 'N';
     header[1] = 'E';
     header[2] = 'S';
@@ -1532,7 +1532,7 @@ fn cmdPackSnes(alloc: std.mem.Allocator, io: std.Io, args: anytype) !void {
 
     // Write title if provided
     if (title_opt) |t| {
-        var title_bytes = [_]u8{0x20} ** 21;
+        var title_bytes: [21]u8 = @splat(0x20);
         const copy_len = @min(t.len, 21);
         @memcpy(title_bytes[0..copy_len], t[0..copy_len]);
         @memcpy(rom[hdr_off..][0..21], &title_bytes);
@@ -1563,7 +1563,7 @@ fn cmdPackSnes(alloc: std.mem.Allocator, io: std.Io, args: anytype) !void {
     defer out_f.close(io);
 
     if (add_smc) {
-        const smc_hdr = [_]u8{0x00} ** 512;
+        const smc_hdr: [512]u8 = @splat(0x00);
         try out_f.writeStreamingAll(io, &smc_hdr);
     }
     try out_f.writeStreamingAll(io, rom);
