fix: clear stale Development CloudKit state on first Production run

Mac (CloudKitPusher):
- On first launch with icloud-container-environment=Production, wipe
  ServerRecordCache and engine state persisted from v2.4.3 which used
  Development CloudKit. Development recordChangeTags embedded as base
  records caused 'server record changed' errors in Production, silently
  preventing MacStatus/AgentConfig from ever reaching the server.
- Keyed by 'doomcoder.ckpusher.environment.v1' — future env changes
  also trigger the wipe automatically.

iOS (CompanionSyncEngine):
- Same migration: clear engine state, serverRecords, and MacStatusStore
  (cached entries from Development fetches) on first Production run.
  Keyed by 'ck.ios.environment.v1'.
- After the wipe, the engine does a fresh fetch from the Production zone
  and properly receives the Mac's MacStatus record.

iOS version: 2.4.1 → 2.4.2 (build 3) — TestFlight submission.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: katipally

DoomCoder/AgentTracking/CloudKitPusher.swift

@@ -142,6 +142,24 @@ final class CloudKitPusher {
             return
         }
 
+        // ── Environment migration guard ──────────────────────────────────
+        // v2.4.3 used the Development CloudKit environment (no explicit
+        // icloud-container-environment entitlement). v2.4.4 adds Production.
+        // Any CKSyncEngine state serialisation and ServerRecordCache blobs
+        // written under Development are incompatible with Production (different
+        // server-side record-change tags, sync tokens, etc.).
+        // On the first launch in Production we wipe both so the engine starts
+        // fresh: records are saved without a stale base changeTag, meaning
+        // CloudKit creates them from scratch in the Production database.
+        let environmentKey = "doomcoder.ckpusher.environment.v1"
+        let currentEnv = "production"
+        if UserDefaults.standard.string(forKey: environmentKey) != currentEnv {
+            logger.notice("ckpusher: environment changed → wiping stale engine state and server-record cache")
+            serverRecords.clear()
+            UserDefaults.standard.removeObject(forKey: "doomcoder.ckpusher.engineState.v1")
+            UserDefaults.standard.set(currentEnv, forKey: environmentKey)
+        }
+
         let stateKey = "doomcoder.ckpusher.engineState.v1"
         let state: CKSyncEngine.State.Serialization?
         if let data = UserDefaults.standard.data(forKey: stateKey),

DoomCoderCompanion/DoomCoderCompanion.xcodeproj/project.pbxproj

@@ -424,7 +424,7 @@
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 				CODE_SIGN_STYLE = Automatic;
 				COPY_PHASE_STRIP = NO;
-				CURRENT_PROJECT_VERSION = 2;
+				CURRENT_PROJECT_VERSION = 3;
 				DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
 				DEVELOPMENT_TEAM = A9P2388PHM;
 				ENABLE_NS_ASSERTIONS = NO;
@@ -439,7 +439,7 @@
 				GCC_WARN_UNUSED_FUNCTION = YES;
 				GCC_WARN_UNUSED_VARIABLE = YES;
 				IPHONEOS_DEPLOYMENT_TARGET = 26.0;
-				MARKETING_VERSION = 2.4.1;
+				MARKETING_VERSION = 2.4.2;
 				MTL_ENABLE_DEBUG_INFO = NO;
 				MTL_FAST_MATH = YES;
 				OTHER_LDFLAGS = "$(inherited) -ObjC";
@@ -505,7 +505,7 @@
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 				CODE_SIGN_STYLE = Automatic;
 				COPY_PHASE_STRIP = NO;
-				CURRENT_PROJECT_VERSION = 2;
+				CURRENT_PROJECT_VERSION = 3;
 				DEBUG_INFORMATION_FORMAT = dwarf;
 				DEVELOPMENT_TEAM = A9P2388PHM;
 				ENABLE_STRICT_OBJC_MSGSEND = YES;
@@ -526,7 +526,7 @@
 				GCC_WARN_UNUSED_FUNCTION = YES;
 				GCC_WARN_UNUSED_VARIABLE = YES;
 				IPHONEOS_DEPLOYMENT_TARGET = 26.0;
-				MARKETING_VERSION = 2.4.1;
+				MARKETING_VERSION = 2.4.2;
 				MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
 				MTL_FAST_MATH = YES;
 				ONLY_ACTIVE_ARCH = YES;

DoomCoderCompanion/DoomCoderCompanion/Sync/CompanionSyncEngine.swift

@@ -125,6 +125,21 @@ final class CompanionSyncEngine: NSObject {
 
         if syncEngine != nil { syncEngine = nil }
 
+        // ── Engine state migration ───────────────────────────────────────
+        // Prior to v2.4.1 the engine state may have been written when the Mac
+        // was using Development CloudKit (before we added the explicit
+        // icloud-container-environment: Production entitlement). Stale sync
+        // tokens from Development will cause the Production engine to skip
+        // records that were never fetched from Production. Clear once.
+        let envKey = "ck.ios.environment.v1"
+        if sharedDefaults.string(forKey: envKey) != "production" {
+            print("[CompanionSyncEngine] env migration: wiping stale engine state & server-record cache")
+            sharedDefaults.removeObject(forKey: Self.engineStateKey)
+            serverRecords.clear()
+            MacStatusStore.shared.clear()
+            sharedDefaults.set("production", forKey: envKey)
+        }
+
         // Restore persisted engine state
         let serialization: CKSyncEngine.State.Serialization? = {
             guard let data = sharedDefaults.data(forKey: Self.engineStateKey),