Skip to content

Fix bug causing broken login state w/ malformed cookie #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmann345 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix bug causing broken login state w/ malformed cookie #229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions lua/leetcode/cache/cookie.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@ local Cookie = {}
---
---@return string|nil
function Cookie.set(str)
local _, cerr = Cookie.parse(str)
local cookie, cerr = Cookie.parse(str)
if cerr then
return cerr
end

file:write(str, "w")
file:write(cookie.str, "w")
local auth_api = require("leetcode.api.auth")
local _, aerr = auth_api.user()

Expand Down Expand Up @@ -86,6 +86,26 @@ end
---
---@return lc.cache.Cookie|nil, string|nil
function Cookie.parse(str)
str = str:match("^%s*(.-)%s*$")

-- Strip text surrounding the cookie line
if str:find("[\r\n]") then
local cookie_line
for line in str:gmatch("[^\r\n]+") do
if line:find("csrftoken=") and line:find("LEETCODE_SESSION=") then
cookie_line = line:match("^%s*(.-)%s*$")
break
end
end

if not cookie_line then
return nil, "Bad token format"
end
str = cookie_line
end

str = str:gsub("^[Cc]ookie:%s*", "", 1)

local csrf = str:match("csrftoken=([^;]+)")
if not csrf or csrf == "" then
return nil, "Bad csrf token format"
Expand Down