address reviews

Author: mjudeikis

backend/controllers/bindableresourcesrequest/bindableresourcesrequest_controller.go

@@ -313,7 +313,7 @@ func (r *reconciler) ensureBindingResponseSecret(
 	response := kubebindv1alpha2.BindingResourceResponse{
 		TypeMeta: metav1.TypeMeta{
 			APIVersion: kubebindv1alpha2.SchemeGroupVersion.String(),
-			Kind:       kubebindv1alpha2.KindBindingResourceResponse,
+			Kind:       "BindingResourceResponse",
 		},
 		Kubeconfig: kubeconfig,
 	}
@@ -333,7 +333,7 @@ func (r *reconciler) ensureBindingResponseSecret(
 	// Build owner reference - the secret is owned by the BindableResourcesRequest
 	ownerRef := metav1.OwnerReference{
 		APIVersion: kubebindv1alpha2.SchemeGroupVersion.String(),
-		Kind:       kubebindv1alpha2.KindBindableResourcesRequest,
+		Kind:       "BindableResourcesRequest",
 		Name:       req.Name,
 		UID:        req.UID,
 		Controller: func() *bool { b := true; return &b }(),

backend/server.go

@@ -328,11 +328,10 @@ func (s *Server) Run(ctx context.Context) error {
 
 	if !s.Config.Options.FrontendDisabled {
 		return s.WebServer.Start(ctx)
-	} else {
-		logger.Info("Frontend is disabled; skipping web server start")
-		<-ctx.Done()
-		return nil
 	}
+	logger.Info("Frontend is disabled; skipping web server start")
+	<-ctx.Done()
+	return nil
 }
 
 func (s *Server) seedCluster(ctx context.Context) error {

pkg/konnector/controllers/servicebindingbundle/servicebindingbundle_reconcile.go

@@ -218,7 +218,7 @@ func (r *reconciler) syncAPIServiceBindings(ctx context.Context, bundle *kubebin
 	for _, binding := range allBindings {
 		for _, ownerRef := range binding.OwnerReferences {
 			if ownerRef.APIVersion == kubebindv1alpha2.SchemeGroupVersion.String() &&
-				ownerRef.Kind == kubebindv1alpha2.KindAPIServiceBindingBundle &&
+				ownerRef.Kind == "APIServiceBindingBundle" &&
 				ownerRef.Name == bundle.Name &&
 				ownerRef.UID == bundle.UID {
 				ownedBindings[binding.Name] = binding
@@ -252,7 +252,7 @@ func (r *reconciler) syncAPIServiceBindings(ctx context.Context, bundle *kubebin
 				OwnerReferences: []metav1.OwnerReference{
 					{
 						APIVersion: kubebindv1alpha2.SchemeGroupVersion.String(),
-						Kind:       kubebindv1alpha2.KindAPIServiceBindingBundle,
+						Kind:       "APIServiceBindingBundle",
 						Name:       bundle.Name,
 						UID:        bundle.UID,
 						Controller: func() *bool { b := true; return &b }(),

sdk/apis/kubebind/v1alpha2/register.go

@@ -33,22 +33,6 @@ const (
 
 	// GroupVersion is the group version used in this package.
 	GroupVersion = "v1alpha2"
-
-	// Kind constants for the types in this package.
-	KindBoundSchema              = "BoundSchema"
-	KindAPIServiceBinding        = "APIServiceBinding"
-	KindAPIServiceBindingBundle  = "APIServiceBindingBundle"
-	KindAPIServiceExport         = "APIServiceExport"
-	KindAPIServiceExportRequest  = "APIServiceExportRequest"
-	KindAPIServiceNamespace      = "APIServiceNamespace"
-	KindClusterBinding           = "ClusterBinding"
-	KindBindingProvider          = "BindingProvider"
-	KindBindingResourceResponse  = "BindingResourceResponse"
-	KindAPIServiceExportTemplate = "APIServiceExportTemplate"
-	KindCollection               = "Collection"
-	KindCluster                  = "Cluster"
-	KindBindableResourcesRequest = "BindableResourcesRequest"
-	KindAPIConversion            = "APIConversion"
 )
 
 // SchemeGroupVersion is group version used to register these objects.