review nits

Author: mjudeikis

backend/controllers/serviceexportrequest/serviceexportrequest_reconcile.go

@@ -378,14 +378,14 @@ func (r *reconciler) ensureAPIServiceNamespaces(ctx context.Context, cl client.C
 
 	// TODO(mjudeikis): We have this object above already, pass it down to avoid extra get.
 	export := &kubebindv1alpha2.APIServiceExport{}
-	if err := cl.Get(ctx, client.ObjectKey{Namespace: req.Namespace, Name: req.Name}, export); err != nil {
+	if err := cl.Get(ctx, client.ObjectKeyFromObject(req), export); err != nil {
 		return fmt.Errorf("failed to get APIServiceExport %s/%s: %w", req.Namespace, req.Name, err)
 	}
 
 	for _, ns := range req.Spec.Namespaces {
 		apiServiceNamespace := helpers.APIServiceNamespaceFromExport(export, ns.Name)
 		currentAPIServiceNamespace := &kubebindv1alpha2.APIServiceNamespace{}
-		err := cache.Get(ctx, client.ObjectKey{Namespace: apiServiceNamespace.Namespace, Name: apiServiceNamespace.Name}, currentAPIServiceNamespace)
+		err := cache.Get(ctx, client.ObjectKeyFromObject(apiServiceNamespace), currentAPIServiceNamespace)
 		if err != nil {
 			if apierrors.IsNotFound(err) {
 				logger.V(1).Info("Creating APIServiceNamespace", "name", apiServiceNamespace.Name, "namespace", apiServiceNamespace.Namespace)

contrib/kcp/README.md

@@ -104,7 +104,7 @@ kubectl kcp bind apiexport root:provider:cowboys-stable
 ```bash
 kubectl get logicalcluster
 # NAME      PHASE   URL                                                    AGE
-# cluster   Ready   https://192.168.2.166:6443/clusters/1f4roigyt6meiaf8 
+# cluster   Ready   https://192.168.2.166:6443/clusters/1f4roigyt6meiaf8
 ```
 
 ## Consumer
@@ -169,9 +169,6 @@ kubectl apply -f contrib/kcp/deploy/examples/cowboy.yaml
 kubectl apply -f contrib/kcp/deploy/examples/sheriff.yaml
 ```
 
-
-
-
 ## Debug
 
 ```bash

pkg/konnector/controllers/cluster/namespacelifecycle/namespacelifecycle_controller.go

@@ -221,15 +221,11 @@ func (c *controller) process(ctx context.Context, key string) error {
 		return nil // we cannot do anything
 	}
 
-	current, err := c.getServiceNamespace(snsNamespace, name)
-	if err != nil && !errors.IsNotFound(err) {
-		return err
-	}
-
-	switch {
-	case errors.IsNotFound(err):
+	if current, err := c.getServiceNamespace(snsNamespace, name); errors.IsNotFound(err) {
 		return c.handleNamespaceDeletion(ctx, snsNamespace, name)
-	default:
+	} else if err != nil {
+		return err
+	} else {
 		return c.handleNamespaceLifecycle(ctx, current)
 	}
 }