Skip to content

Commit 99fae85

Browse files
committed
Fix namedResource->namedResources
Signed-off-by: Mangirdas Judeikis <mangirdas@judeikis.lt> On-behalf-of: @SAP mangirdas.judeikis@sap.com
1 parent cd3124d commit 99fae85

3 files changed

Lines changed: 15 additions & 15 deletions

File tree

pkg/konnector/controllers/cluster/claimedresources/claimedresources_controller.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -374,7 +374,7 @@ func (c *controller) enqueueServiceNamespace(logger klog.Logger, obj interface{}
374374
// We need to list all the object which might not got synced at consumer side too:
375375
var sel labels.Selector
376376
switch v := c.claim.Selector; {
377-
case v.LabelSelector == nil && len(v.NamedResource) == 0:
377+
case v.LabelSelector == nil && len(v.NamedResources) == 0:
378378
sel = labels.Everything()
379379
case v.LabelSelector != nil:
380380
var err error
@@ -383,9 +383,9 @@ func (c *controller) enqueueServiceNamespace(logger klog.Logger, obj interface{}
383383
runtime.HandleError(err)
384384
return
385385
}
386-
case len(v.NamedResource) > 0:
386+
case len(v.NamedResources) > 0:
387387
// namedResource-only: fetch specific objects from cache and enqueue
388-
for _, nr := range v.NamedResource {
388+
for _, nr := range v.NamedResources {
389389
// Build consumer cache key; empty namespace implies cluster-scoped
390390
key := nr.Name
391391
if nr.Namespace != "" {

pkg/resources/resources.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ func IsClaimed(selector kubebindv1alpha2.Selector, obj *unstructured.Unstructure
3030
return false
3131
}
3232
// Empty selector selects everything
33-
if selector.LabelSelector == nil && len(selector.NamedResource) == 0 {
33+
if selector.LabelSelector == nil && len(selector.NamedResources) == 0 {
3434
return true
3535
}
3636

@@ -52,9 +52,9 @@ func IsClaimed(selector kubebindv1alpha2.Selector, obj *unstructured.Unstructure
5252
}
5353

5454
// Check named resources if specified
55-
if len(selector.NamedResource) > 0 {
55+
if len(selector.NamedResources) > 0 {
5656
namedResourceMatches = false // Default to false, must match at least one
57-
for _, nr := range selector.NamedResource {
57+
for _, nr := range selector.NamedResources {
5858
if nr.Namespace != "" && nr.Namespace != obj.GetNamespace() {
5959
continue
6060
}

pkg/resources/resources_test.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ func TestSelector_IsClaimed(t *testing.T) {
9595
{
9696
name: "named resource selector should match exact name and namespace",
9797
selector: kubebindv1alpha2.Selector{
98-
NamedResource: []kubebindv1alpha2.NamedResource{
98+
NamedResources: []kubebindv1alpha2.NamedResource{
9999
{
100100
Name: "test-obj",
101101
Namespace: "test-ns",
@@ -115,7 +115,7 @@ func TestSelector_IsClaimed(t *testing.T) {
115115
{
116116
name: "named resource selector should match name when namespace is empty",
117117
selector: kubebindv1alpha2.Selector{
118-
NamedResource: []kubebindv1alpha2.NamedResource{
118+
NamedResources: []kubebindv1alpha2.NamedResource{
119119
{
120120
Name: "test-obj",
121121
Namespace: "",
@@ -135,7 +135,7 @@ func TestSelector_IsClaimed(t *testing.T) {
135135
{
136136
name: "named resource selector should not match different name",
137137
selector: kubebindv1alpha2.Selector{
138-
NamedResource: []kubebindv1alpha2.NamedResource{
138+
NamedResources: []kubebindv1alpha2.NamedResource{
139139
{
140140
Name: "other-obj",
141141
Namespace: "test-ns",
@@ -155,7 +155,7 @@ func TestSelector_IsClaimed(t *testing.T) {
155155
{
156156
name: "named resource selector should not match different namespace",
157157
selector: kubebindv1alpha2.Selector{
158-
NamedResource: []kubebindv1alpha2.NamedResource{
158+
NamedResources: []kubebindv1alpha2.NamedResource{
159159
{
160160
Name: "test-obj",
161161
Namespace: "other-ns",
@@ -175,7 +175,7 @@ func TestSelector_IsClaimed(t *testing.T) {
175175
{
176176
name: "named resource selector should match one of multiple resources",
177177
selector: kubebindv1alpha2.Selector{
178-
NamedResource: []kubebindv1alpha2.NamedResource{
178+
NamedResources: []kubebindv1alpha2.NamedResource{
179179
{
180180
Name: "other-obj",
181181
Namespace: "test-ns",
@@ -223,7 +223,7 @@ func TestSelector_IsClaimed(t *testing.T) {
223223
"app": "test",
224224
},
225225
},
226-
NamedResource: []kubebindv1alpha2.NamedResource{
226+
NamedResources: []kubebindv1alpha2.NamedResource{
227227
{
228228
Name: "test-obj",
229229
Namespace: "test-ns",
@@ -251,7 +251,7 @@ func TestSelector_IsClaimed(t *testing.T) {
251251
"app": "different",
252252
},
253253
},
254-
NamedResource: []kubebindv1alpha2.NamedResource{
254+
NamedResources: []kubebindv1alpha2.NamedResource{
255255
{
256256
Name: "test-obj",
257257
Namespace: "test-ns",
@@ -279,7 +279,7 @@ func TestSelector_IsClaimed(t *testing.T) {
279279
"app": "test",
280280
},
281281
},
282-
NamedResource: []kubebindv1alpha2.NamedResource{
282+
NamedResources: []kubebindv1alpha2.NamedResource{
283283
{
284284
Name: "other-obj",
285285
Namespace: "test-ns",
@@ -307,7 +307,7 @@ func TestSelector_IsClaimed(t *testing.T) {
307307
"app": "secrets",
308308
},
309309
},
310-
NamedResource: []kubebindv1alpha2.NamedResource{
310+
NamedResources: []kubebindv1alpha2.NamedResource{
311311
{
312312
Name: "test-secret",
313313
Namespace: "default",

0 commit comments

Comments
 (0)