update revew

Author: mjudeikis

Makefile

@@ -409,33 +409,42 @@ build-web:
 PLATFORMS ?= linux/$(ARCH)
 .PHONY: image-local
 image-local:
-	@echo "Building multi-arch images locally with tag $(REV) for platforms: $(PLATFORMS)"
+	@echo "Building images locally with tag $(REV) for platforms: $(PLATFORMS)"
 	@command -v docker >/dev/null 2>&1 || { echo "docker not found. Please install Docker"; exit 1; }
 	@docker buildx version >/dev/null 2>&1 || { echo "docker buildx not found. Please enable buildx in Docker"; exit 1; }
 
 	@# Create buildx builder if it doesn't exist
 	@docker buildx create --name kube-bind-builder --use 2>/dev/null || docker buildx use kube-bind-builder 2>/dev/null || true
 	@docker buildx inspect --bootstrap >/dev/null 2>&1
 
-	@echo "Building konnector multi-arch image locally..."
+	@# Check if building for multiple platforms
+	@if [[ "$(PLATFORMS)" == *","* ]]; then \
+		echo "Multi-platform build detected. Images will be pushed to registry instead of loaded locally."; \
+		LOAD_FLAG="--push"; \
+	else \
+		echo "Single platform build. Images will be loaded to local Docker daemon."; \
+		LOAD_FLAG="--load"; \
+	fi && \
+	\
+	echo "Building konnector image..." && \
 	docker buildx build \
 		--platform $(PLATFORMS) \
 		--build-arg LDFLAGS="$(LDFLAGS)" \
 		-t $(IMAGE_REPO)/konnector:$(REV) \
 		-f Dockerfile.konnector \
-		--load .
-
-	@echo "Building backend multi-arch image locally..."
+		$$LOAD_FLAG . && \
+	\
+	echo "Building backend image..." && \
 	docker buildx build \
 		--platform $(PLATFORMS) \
 		--build-arg LDFLAGS="$(LDFLAGS)" \
 		-t $(IMAGE_REPO)/backend:$(REV) \
 		-f Dockerfile \
-		--load .
-
-	@echo "Successfully built multi-arch local images:"
-	@echo "  $(IMAGE_REPO)/konnector:$(REV) ($(PLATFORMS))"
-	@echo "  $(IMAGE_REPO)/backend:$(REV) ($(PLATFORMS))"
+		$$LOAD_FLAG . && \
+	\
+	echo "Successfully built images:" && \
+	echo "  $(IMAGE_REPO)/konnector:$(REV) ($(PLATFORMS))" && \
+	echo "  $(IMAGE_REPO)/backend:$(REV) ($(PLATFORMS))"
 
 # Kind cluster configuration
 KIND_CLUSTER ?= kube-bind

docs/content/contributing/index.md

@@ -53,7 +53,7 @@ that might not be obvious to the contributor.
 ### Approvers
 
 Approvers are responsible for sign-off on the acceptance of the contribution. In essence, approval indicates that the
-change is desired and good for the project, aligns with code, api, and system conventions, and appears to follow all required
+change is desired and good for the project, aligns with code, API, and system conventions, and appears to follow all required
 process including adequate testing, documentation, follow ups, or notifications to other areas who might be interested
 or affected by the change.
 

docs/content/developers/dev-environments.md

@@ -311,7 +311,7 @@ All the instructions assume you have already cloned the kube-bind repository and
         staticClients:
         - id: kube-bind
             redirectURIs:
-            - 'http://${BACKEND_HOST_IP}:8080/callback'
+            - 'http://${BACKEND_HOST_IP}:8080/api/callback'
             name: 'Kube Bind'
             secret: ZXhhbXBsZS1hcHAtc2VjcmV0
 
@@ -386,13 +386,13 @@ All the instructions assume you have already cloned the kube-bind repository and
         create deployment mangodb \
         --image ghcr.io/kube-bind/backend:main \
         --port 8080 \
-        -- /ko-app/backend \
+        -- /bin/backend \
             --listen-address 0.0.0.0:8080 \
             --external-address "${BACKEND_KUBE_API_EXTERNAL_ADDRESS}" \
             --oidc-issuer-client-secret=ZXhhbXBsZS1hcHAtc2VjcmV0 \
             --oidc-issuer-client-id=kube-bind \
             --oidc-issuer-url=http://${BACKEND_HOST_IP}:5556/dex \
-            --oidc-callback-url=http://${BACKEND_HOST_IP}:8080/callback \
+            --oidc-callback-url=http://${BACKEND_HOST_IP}:8080/api/callback \
             --pretty-name="BigCorp.com" \
             --namespace-prefix="kube-bind-" \
             --cookie-signing-key=bGMHz7SR9XcI9JdDB68VmjQErrjbrAR9JdVqjAOKHzE= \
@@ -442,7 +442,7 @@ All the instructions assume you have already cloned the kube-bind repository and
     kind: Cluster
     name: app
     networking:
-    apiServerAddress: ${APP_HOST_IP}
+        apiServerAddress: ${APP_HOST_IP}
     EOF_AppClusterDefinition
     ```
 
@@ -498,12 +498,13 @@ All the instructions assume you have already cloned the kube-bind repository and
     apiVersion: mangodb.com/v1alpha1
     kind: MangoDB
     metadata:
-    name: my-db
+      name: my-db
     spec:
-    tokenSecret: my-secret
-    region: eu-west-1
-    tier: Shared
+      tokenSecret: my-secret
+      region: eu-west-1
+      tier: Shared
     EOF_MangoDBDefinition
+    
     kubectl describe mangodb my-db
     ```
 

docs/content/developers/index.md

@@ -1,6 +1,6 @@
 # Developers
 
-Welcome to the kube-bind developer documentation! This section contains information for developers who want to contribute to the kube-bind project, including guides on setting up a development environment, understanding the architecture, and contributing code, and api documentation.
+Welcome to the kube-bind developer documentation! This section contains information for developers who want to contribute to the kube-bind project, including guides on setting up a development environment, understanding the architecture, and contributing code, and API documentation.
 
 ## Developer Guide