Refactor existing APIs to use APIResourceSchema, BoundAPIResourceSchema for service exposure#261
Merged
Merged
Conversation
cnvergence
force-pushed
the
v1alpha2-apiserviceexport
branch
3 times, most recently
from
1798a1d to
3ff4507
Compare
cnvergence
force-pushed
the
v1alpha2-apiserviceexport
branch
2 times, most recently
from
e03489a to
1c1b2c9
Compare
cnvergence
changed the title
cnvergence
force-pushed
the
v1alpha2-apiserviceexport
branch
4 times, most recently
from
5e86fa4 to
b8fcd7a
Compare
cnvergence
force-pushed
the
v1alpha2-apiserviceexport
branch
3 times, most recently
from
32a7ed7 to
d95c9af
Compare
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
cnvergence
force-pushed
the
v1alpha2-apiserviceexport
branch
from
48d1dce to
783b6c1
Compare
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
cnvergence
force-pushed
the
v1alpha2-apiserviceexport
branch
from
783b6c1 to
a8bfcb8
Compare
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
cnvergence
force-pushed
the
v1alpha2-apiserviceexport
branch
from
627f0d2 to
8a210e6
Compare
mjudeikis
reviewed
Jun 11, 2025
|
|
||
| source "$(dirname "$0")/host-ip.sh" | ||
| get_host_ip | ||
| DEFAULT_KONNECTOR_IMAGE="ghcr.io/kube-bind/konnector:v0.4.6" |
Contributor
There was a problem hiding this comment.
This will break as soon as we merge this. repo has "latest" image, should we do the un-holy thing and just use latest here?
Member
Author
There was a problem hiding this comment.
I wasn't aware of that, for now, I wanted a default for "sane" tested version
Contributor
There was a problem hiding this comment.
But test uses APISchemas already, but this implementation does not support it :D
Member
Author
There was a problem hiding this comment.
No, I meant for running the example-backend kind setup with 0.4.8 version of images and kube-bind cli.
We can use the latest as the default, I don't mind
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
V1alpha2 apiserviceexport patch
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
mjudeikis
added a commit
to mjudeikis/kube-bind
that referenced
this pull request
Aug 18, 2025
…ma for service exposure (kbind-dev#261) * Refactor APIServiceExport and APIServiceExportRequest for v1alpha2 Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com * storage version Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com * add APIServiceBinding v1alpha2 Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com * update konnector to v1alpha2 Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com * update cmd and example-backend to v1alpha2 Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com * update go.mod Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com * refactor konnector serviceexport and servicebinding controllers Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com * update service binding reconciler Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com * refactor example backend Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> * refactor example backend Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> * fix lint Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com * remove validation rules Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com * add crds to e2e Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com * add rbac e2e Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com * setup with local kind Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com * fix backend kind cluster Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com * make apiresourceschemas cluster scoped Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com * add version gate * nit * Move towards single kind cluster * Add additional perms to read schemas * Fix conditions * fix race condition * fix test * update readme * add short names to crds and prealloc hashes Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com * update readme, move kcp setup to quickstart page Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com --------- Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> Co-authored-by: Mangirdas Judeikis <mangirdas@judeikis.lt> On-behalf-of: @SAP mangirdas.judeikis@sap.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Fixes #255
Release Notes