Skip to content

Various nits, fixes and cleanup#311

Merged
mjudeikis merged 13 commits into
kbind-dev:mainfrom
ntnn:fix-make
Sep 18, 2025
Merged

Various nits, fixes and cleanup#311
mjudeikis merged 13 commits into
kbind-dev:mainfrom
ntnn:fix-make

Conversation

@ntnn

@ntnn ntnn commented Sep 18, 2025

Copy link
Copy Markdown
Member

Summary

  1. Ensure make recipes work across all modules
  2. Fix sdk/client importing sdk/apis by merging into one package sdk
    This causes errors when the APIs change but are not present in main, because the generated client tries to import from sdk/apis which upstream isn't updated yet ofc.
  3. Fix various fix golangci-lint found (which were hidden because lint only ran on the root module)
  4. Fix code generator by updating kcp-dev/code-generator (not sure why but v2.3.1 wouldn't build due to a dependency erroring; v2.4.0 works though)
  5. Tidy all modules
  6. Also fix the make help output

This was actually intended to be a smaller PR with just the recipe changes but you know about the 99 bugs

What Type of PR Is This?

/kind bug
/kind cleanup

Related Issue(s)

Fixes #

Release Notes

Merge `sdk/client` and `sdk/apis` into `sdk` package

@ntnn ntnn requested a review from a team as a code owner September 18, 2025 10:28
mjudeikis
mjudeikis previously approved these changes Sep 18, 2025

@mjudeikis mjudeikis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally I would say - let's not split sdk/{client,api}
But as we are working towards converting all code to be multicluster-runtime, and hence dont need generated client anymore - sdk/client should go away very soon.
So this makes code simplier for now, and easier to consume.

Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>

@mjudeikis mjudeikis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets ship this.

@mjudeikis mjudeikis merged commit d9225a4 into kbind-dev:main Sep 18, 2025
9 checks passed
@ntnn ntnn deleted the fix-make branch September 18, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants