Move kcp/ to contrib/kcp/#314
Merged
Merged
Conversation
ntnn
force-pushed
the
contribs
branch
5 times, most recently
from
4cb8d93 to
8365313
Compare
ntnn
commented
Sep 19, 2025
| verify-modules: modules # Verify go modules are up to date | ||
| @for MOD in $(GOMODS); do \ | ||
| (cd $$MOD; echo "Verifying $$MOD"; if ! git diff --quiet HEAD -- go.mod go.sum; then echo "[$$MOD] go modules are out of date, please run 'make modules'"; exit 1; fi; ) \ | ||
| (cd $$MOD; echo "Verifying $$MOD"; if ! git diff --quiet HEAD -- go.mod go.sum; then git diff -- go.mod go.sum; echo "[$$MOD] go modules are out of date, please run 'make modules'"; exit 1; fi; ) \ |
Member
Author
There was a problem hiding this comment.
Added this because a verify CI job failed without any indication what is different. This way we'll at least see why the modules are different.
cnvergence
previously approved these changes
Sep 19, 2025
Member
|
Is the e2e test scenario a part of #296? |
Member
Author
|
Ah yes, that the poc MJ did; I'll remove that that shouldn't be in yet. I wouldn't hurt but it would be cleaner to add it later when its done. |
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com> Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com> Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com> Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com> Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
cnvergence
approved these changes
Sep 19, 2025
mjudeikis
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Just the move so actualy changes aren't lost in the noise later.
I was considering adding a
test-contribsrecipe, but the unit test recipe is already module aware so that would be overkill.The
test-e2eshould stay as it is as it needs the setup with kcp and dex, which may not be required for all contribs tests.There's also the
buildrecipe that directly targetskcp-init. I've left it for now, I'm not yet sure if the contribs/ should be self-contained or if the makefile should build absolutely everything.Same for codegen - I could see
codegenlooking into the makefiles of the contribs and execute a codegen target if it exists. At the moment the codegen script calls into the kcp makefile explicitly.What Type of PR Is This?
/kind cleanup
Related Issue(s)
Fixes #
Release Notes