Skip to content

Revert deps dump#331

Merged
mjudeikis merged 1 commit into
kbind-dev:mainfrom
mjudeikis:mjudeikis/revert.dep.bump
Oct 1, 2025
Merged

Revert deps dump#331
mjudeikis merged 1 commit into
kbind-dev:mainfrom
mjudeikis:mjudeikis/revert.dep.bump

Conversation

@mjudeikis

@mjudeikis mjudeikis commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

Summary

controller-runtime runner is not yet working. Clusters are not engaged as provider is not auto-started

What Type of PR Is This?

/kind bug

Related Issue(s)

Fixes #

Release Notes

Revert multicluster-runtime bump.

Summary by CodeRabbit

  • New Features

    • No user-facing changes in this release.
  • Refactor

    • Streamlined backend configuration by adopting a unified multicluster provider interface.
    • Removed redundant internal abstractions to simplify provider integration and initialization.
  • Chores

    • Updated multicluster-related dependencies to newer versions for compatibility and maintenance.
    • General codebase cleanup aligned with the new provider integration.

@mjudeikis mjudeikis requested a review from a team as a code owner October 1, 2025 10:02
@coderabbitai

coderabbitai Bot commented Oct 1, 2025

Copy link
Copy Markdown

Walkthrough

Replaces backend.Config.Provider’s type with multicluster.Provider, removes the local MultiClusterProvider interface, updates imports accordingly, and adjusts go.mod replace directives to different multicluster-related module SHAs.

Changes

Cohort / File(s) Summary
Backend provider API
backend/config.go, backend/provider/provider.go
Config.Provider type switched from provider.MultiClusterProvider to multicluster.Provider; removed provider.MultiClusterProvider interface and related multicluster import.
Module replace updates
go.mod
Updated replace directives: switched multicluster-provider and sigs.k8s.io/multicluster-runtime to earlier commit SHAs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Update docs for v0.5 #324 — Adjusts the same backend provider API, including backend.Config.Provider and backend/provider interface definitions.

Suggested reviewers

  • xrstf
  • moadqassem

Poem

A whisk of wires, a hop through code,
I swapped a path on the multicluster road.
One interface gone—light as a tuft—
Provider now plugs in with less fluff.
Thump-thump, I merge with careful cheer,
A tidy warren for clusters near. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Description Check ⚠️ Warning While the description uses the correct template headings, the Summary section describes a problem rather than summarizing the changes made, and the Related Issue(s) section contains a placeholder (“Fixes #”) without an actual issue reference. Please expand the Summary to outline what files were changed and how the dependency versions were reverted, and either link to a real issue in the Related Issue(s) section or remove the placeholder if there is no associated issue.
Title Check ❓ Inconclusive The title “Revert deps dump” is overly vague and does not clearly communicate the primary change of this pull request, which is reverting the dependency bump for the multicluster-runtime and related modules; it also uses non-specific terminology (“deps dump”) rather than describing what was actually reverted. Please update the title to explicitly reference the main change, for example “Revert multicluster-runtime dependency bump” or a similarly concise description that clearly states what is being reverted.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b3e214e and 9bd9364.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (3)
  • backend/config.go (1 hunks)
  • backend/provider/provider.go (0 hunks)
  • go.mod (2 hunks)
💤 Files with no reviewable changes (1)
  • backend/provider/provider.go
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Generate and push docs
  • GitHub Check: lint
  • GitHub Check: verify
  • GitHub Check: go-test
  • GitHub Check: go-test-e2e
🔇 Additional comments (2)
go.mod (1)

16-16: Verify revert addresses controller-runtime runner issue and document lost fixes.
Reverting to commits 3d31cbb06ebe (provider) and d8ebc45e169b (runtime) should restore the controller-runtime runner—confirm these commits resolve the broken behavior and list any fixes or features dropped by removing commits a1b0eea41697 and 419f38e2cced. A check for security advisories against sigs.k8s.io/multicluster-runtime returned no known vulnerabilities; decide on a long-term strategy for replacing personal forks with official or org-maintained releases.

backend/config.go (1)

38-38: Verify external multicluster.Provider interface compatibility.

Ensure that the imported version of sigs.k8s.io/multicluster-runtime/pkg/multicluster defines a Provider interface matching all methods used by config.Provider (notably in the call to mcmanager.New(...) at line 126 and any downstream controllers). Confirm no methods were added, removed, or renamed.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mjudeikis mjudeikis merged commit fbbda1c into kbind-dev:main Oct 1, 2025
6 checks passed
mjudeikis added a commit that referenced this pull request Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants