Skip to content

Fix missing kcp=>contrib/kcp renames#336

Merged
mjudeikis merged 1 commit into
kbind-dev:mainfrom
ntnn:fix-contribs
Oct 3, 2025
Merged

Fix missing kcp=>contrib/kcp renames#336
mjudeikis merged 1 commit into
kbind-dev:mainfrom
ntnn:fix-contribs

Conversation

@ntnn

@ntnn ntnn commented Oct 2, 2025

Copy link
Copy Markdown
Member

Summary

The modules wasn't actually renamed, leading to other issues

What Type of PR Is This?

/kind bug

Related Issue(s)

Fixes #

Release Notes

NONE

Summary by CodeRabbit

  • Chores
    • Reorganized contrib/kcp module under a new path and aligned internal references for consistency.
    • Standardized bootstrap resource imports within the contrib scope.
    • No functional or interface changes; existing workflows and commands behave as before.
    • No user action required; this is a maintenance update improving repository structure and clarity.

Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn ntnn requested a review from a team as a code owner October 2, 2025 14:11
@coderabbitai

coderabbitai Bot commented Oct 2, 2025

Copy link
Copy Markdown

Walkthrough

Imports and module paths are repointed from kcp/* to contrib/kcp/* across several files, with no logic or API changes. One go.mod module path is updated accordingly. Control flow, functions, and error handling remain unchanged.

Changes

Cohort / File(s) Summary of Changes
Module path update
contrib/kcp/go.mod
Change module declaration from github.com/kube-bind/kube-bind/kcp to github.com/kube-bind/kube-bind/contrib/kcp.
Bootstrap config imports
contrib/kcp/bootstrap/config.go
Update options import path to contrib/kcp/bootstrap/options; no code or API changes.
Core resources import
contrib/kcp/bootstrap/config/core/bootstrap.go
Update resources import path to contrib/kcp/bootstrap/config/core/resources; function calls unchanged.
Server bootstrap imports
contrib/kcp/bootstrap/server.go
Update imports for bootstrap/config/config, bootstrap/config/core, and bootstrap/config/kcp to contrib/kcp/...; logic unchanged.
CLI init command imports
contrib/kcp/cmd/kcp-init/main.go
Update imports for bootstrap and options from kcp/bootstrap/... to contrib/kcp/bootstrap/...; behavior unchanged.
Deploy resources import
contrib/kcp/deploy/bootstrap.go
Update resources import path to contrib/kcp/bootstrap/config/kcp/resources; no functional changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I hopped through paths, a tidy detour,
From kcp to contrib, the routes now sure.
No wires were crossed, no flows askew—
Just signs replaced with something new.
Thump-thump! says my review delight,
Imports aligned, modules light. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description follows the required template headings but leaves the Related Issue(s) section with an unfilled placeholder "Fixes #", indicating the issue reference is incomplete. Please update the Related Issue(s) section to include the actual issue number this pull request fixes or mark it as "None" if there is no associated issue.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly and concisely summarizes the core change of renaming import paths from kcp to contrib/kcp and reflects the main update in this pull request without unnecessary detail or noise.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fbbda1c and 07d48f6.

📒 Files selected for processing (6)
  • contrib/kcp/bootstrap/config.go (1 hunks)
  • contrib/kcp/bootstrap/config/core/bootstrap.go (1 hunks)
  • contrib/kcp/bootstrap/server.go (1 hunks)
  • contrib/kcp/cmd/kcp-init/main.go (1 hunks)
  • contrib/kcp/deploy/bootstrap.go (1 hunks)
  • contrib/kcp/go.mod (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Generate and push docs
  • GitHub Check: verify
  • GitHub Check: lint
  • GitHub Check: go-test-e2e
  • GitHub Check: go-test
🔇 Additional comments (6)
contrib/kcp/cmd/kcp-init/main.go (1)

29-30: LGTM! Import paths correctly updated.

The import paths have been successfully updated to reference contrib/kcp/bootstrap, aligning with the module relocation.

contrib/kcp/deploy/bootstrap.go (1)

35-35: LGTM! Import path correctly updated.

The import path has been successfully updated to reference contrib/kcp/bootstrap/config/kcp/resources, aligning with the module relocation.

contrib/kcp/bootstrap/config.go (1)

28-28: LGTM! Import path correctly updated.

The import path has been successfully updated to reference contrib/kcp/bootstrap/options, aligning with the module relocation.

contrib/kcp/bootstrap/config/core/bootstrap.go (1)

28-28: LGTM! Import path correctly updated.

The import path has been successfully updated to reference contrib/kcp/bootstrap/config/core/resources, aligning with the module relocation.

contrib/kcp/bootstrap/server.go (1)

25-27: LGTM! Import paths correctly updated.

All three import paths have been successfully updated to reference contrib/kcp/bootstrap/config/*, aligning with the module relocation.

contrib/kcp/go.mod (1)

1-1: LGTM: module path updated with no residual references
Search across the repository found no remaining occurrences of the old github.com/kube-bind/kube-bind/kcp path; the update to github.com/kube-bind/kube-bind/contrib/kcp is complete.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mjudeikis mjudeikis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@mjudeikis mjudeikis merged commit a0c558f into kbind-dev:main Oct 3, 2025
6 checks passed
@ntnn ntnn deleted the fix-contribs branch October 3, 2025 06:54
@coderabbitai coderabbitai Bot mentioned this pull request Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants