Skip to content

Replace gopkg.in/headzoo/surf.v1 with github.com/headzoo/surf#337

Merged
mjudeikis merged 1 commit into
kbind-dev:mainfrom
ntnn:same-surf
Oct 3, 2025
Merged

Replace gopkg.in/headzoo/surf.v1 with github.com/headzoo/surf#337
mjudeikis merged 1 commit into
kbind-dev:mainfrom
ntnn:same-surf

Conversation

@ntnn

@ntnn ntnn commented Oct 2, 2025

Copy link
Copy Markdown
Member

Summary

Homogenize the import of surf.

What Type of PR Is This?

/kind cleanup

Related Issue(s)

Fixes #

Release Notes

NONE

Summary by CodeRabbit

  • Chores

    • Updated a third-party HTTP browsing library to its maintained source and cleaned up module dependencies by removing a deprecated entry.
    • General dependency maintenance to improve reliability and future compatibility.
  • Tests

    • Aligned end-to-end tests with the updated library source; test behavior remains unchanged.
  • Notes

    • No user-facing changes or feature impacts.

Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn ntnn requested a review from a team as a code owner October 2, 2025 14:12
@coderabbitai

coderabbitai Bot commented Oct 2, 2025

Copy link
Copy Markdown

Walkthrough

The dependency on gopkg.in/headzoo/surf.v1 was removed from go.mod, and a test file updated its import to github.com/headzoo/surf. No other files or code paths were modified.

Changes

Cohort / File(s) Summary
Dependency update
go.mod
Removed gopkg.in/headzoo/surf.v1 from the require block.
Test import path switch
test/e2e/bind/happy-case_test.go
Updated import from gopkg.in/headzoo/surf.v1 to github.com/headzoo/surf; code usage unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I nibbled the vines from our go.mod bed,
Snipped an old path, hopped forward instead.
Tests still browse the meadow—no fright,
Just a new trail under the same light.
Thump-thump! Dependencies trimmed neat—
Carrots of green, the build tastes sweet. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly and accurately describes the primary change—replacing the surf import path—using clear technical terms without extraneous details, making the change immediately obvious to readers.
Description Check ✅ Passed The description follows the repository template by providing a summary, PR type, related issues section, and release notes, but the related issues section still contains the placeholder “Fixes #” without an actual issue reference.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fbbda1c and 537fd3d.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • go.mod (0 hunks)
  • test/e2e/bind/happy-case_test.go (1 hunks)
💤 Files with no reviewable changes (1)
  • go.mod
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Generate and push docs
  • GitHub Check: verify
  • GitHub Check: lint
  • GitHub Check: go-test-e2e
  • GitHub Check: go-test

Comment thread test/e2e/bind/happy-case_test.go

@mjudeikis mjudeikis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/apprve

@mjudeikis mjudeikis merged commit ceb9e1c into kbind-dev:main Oct 3, 2025
6 checks passed
@ntnn ntnn deleted the same-surf branch October 3, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants