Provider side namespace management #345
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (8)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the 📝 WalkthroughWalkthroughAdded an immutable Changes
Sequence Diagram(s)(No sequence diagrams generated — changes are schema/manifest updates without control-flow or runtime behavior modifications.) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20–30 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
147a35b to
ac02a91
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (14)
backend/controllers/serviceexport/serviceexport_controller.gois excluded by none and included by nonebackend/controllers/serviceexport/serviceexport_reconcile.gois excluded by none and included by nonebackend/controllers/serviceexportrequest/serviceexportrequest_reconcile.gois excluded by none and included by nonebackend/controllers/servicenamespace/servicenamespace_reconcile.gois excluded by none and included by nonebackend/server.gois excluded by none and included by nonecontrib/kcp/README.mdis excluded by none and included by nonepkg/konnector/controllers/cluster/claimedresources/claimedresources_reconciler.gois excluded by none and included by nonepkg/konnector/controllers/cluster/cluster_controller.gois excluded by none and included by nonepkg/konnector/controllers/cluster/namespacelifecycle/namespacelifecycle_controller.gois excluded by none and included by nonesdk/apis/kubebind/v1alpha2/apiserviceexport_types.gois excluded by none and included by nonesdk/apis/kubebind/v1alpha2/apiserviceexportrequest_types.gois excluded by none and included by nonesdk/apis/kubebind/v1alpha2/helpers/namespaces.gois excluded by none and included by nonesdk/apis/kubebind/v1alpha2/zz_generated.deepcopy.gois excluded by none and included by nonetest/e2e/bind/happy-case_test.gois excluded by none and included by none
📒 Files selected for processing (2)
contrib/kcp/deploy/resources/apiresourceschema-apiserviceexportrequests.kube-bind.io.yaml(1 hunks)deploy/crd/kube-bind.io_apiserviceexportrequests.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: lint
- GitHub Check: go-test-e2e
🔇 Additional comments (1)
deploy/crd/kube-bind.io_apiserviceexportrequests.yaml (1)
215-233: Verify the schema versioning strategy for the newnamespacesfield.The
namespacesfield is present only in v1alpha2 (lines 215–233), while v1alpha1 (line 175) remains unchanged and continues to be served. Since v1alpha1 is still markedserved: true, clients using the v1alpha1 API will not have access to the newnamespacesfield. Confirm that this is the intended behavior and does not break existing client expectations.If v1alpha1 clients should also support the
namespacesfield, add it to the v1alpha1 schema as well (around line 101).Also applies to: 175-175, 457-457
Signed-off-by: Mangirdas Judeikis <mangirdas@judeikis.lt> On-behalf-of: @SAP mangirdas.judeikis@sap.com
27c78b5 to
1468d61
Compare
1468d61 to
fa7fd4f
Compare
9f53e4a to
6c83acc
Compare
6c83acc to
26aed56
Compare
|
/lgtm |
|
/approve |
xrstf
left a comment
There was a problem hiding this comment.
I'm just a Prow boy, living in a Prow world.
Summary
This PR adds
namespacemanagement for the provider side, allowing the pre-creation and ownership ofAPIServiceNamespaceon the provider side. Allows cases where the namespace does not exist on the consumer side but needs to be seeded from the provider.In addition fixex few reconcile bugs where konnector was stuck.
What Type of PR Is This?
/kind feature
/kind bug
Related Issue(s)
Fixes #
Release Notes
Summary by CodeRabbit
New Features
Chores