Skip to content

fix regression: --external-address having no effect anymore#359

Merged
mjudeikis merged 4 commits into
kbind-dev:mainfrom
xrstf:fix-external-address
Nov 5, 2025
Merged

fix regression: --external-address having no effect anymore#359
mjudeikis merged 4 commits into
kbind-dev:mainfrom
xrstf:fix-external-address

Conversation

@xrstf

@xrstf xrstf commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

Summary

The flag got overlooked in #276 and so had no effect anymore since then. This PR brings it back. I also fixed the "Addrees" typo.

What Type of PR Is This?

/kind bug

Release Notes

Fix: `--external-address` had no effect anymore.

@xrstf xrstf requested a review from a team as a code owner November 4, 2025 14:42
@coderabbitai

coderabbitai Bot commented Nov 4, 2025

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • ai-code-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

mjudeikis
mjudeikis previously approved these changes Nov 4, 2025

@mjudeikis mjudeikis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

xrstf added 2 commits November 5, 2025 15:16
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf xrstf force-pushed the fix-external-address branch from 84d856f to 29318d1 Compare November 5, 2025 14:16
On-behalf-of: @SAP christoph.mewes@sap.com
@mjudeikis mjudeikis merged commit e93f220 into kbind-dev:main Nov 5, 2025
6 checks passed
@xrstf xrstf deleted the fix-external-address branch November 6, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants