Embedded OIDC for quickstart#368
Merged
Merged
Conversation
mjudeikis
force-pushed
the
mjudeikis/embed.oidc
branch
4 times, most recently
from
b19e4bc to
f2b947a
Compare
Signed-off-by: Mangirdas Judeikis <mangirdas@judeikis.lt> On-behalf-of: @SAP mangirdas.judeikis@sap.com
mjudeikis
force-pushed
the
mjudeikis/embed.oidc
branch
7 times, most recently
from
ae5df14 to
869d363
Compare
Signed-off-by: Mangirdas Judeikis <mangirdas@judeikis.lt> On-behalf-of: @SAP mangirdas.judeikis@sap.com
mjudeikis
force-pushed
the
mjudeikis/embed.oidc
branch
from
869d363 to
1921309
Compare
Signed-off-by: Mangirdas Judeikis <mangirdas@judeikis.lt> On-behalf-of: @SAP mangirdas.judeikis@sap.com
ntnn
reviewed
Nov 11, 2025
Comment on lines
+48
to
+53
| cmd := exec.Command("uname") | ||
| output, err := cmd.Output() | ||
| if err != nil { | ||
| return false | ||
| } | ||
| return strings.TrimSpace(string(output)) == "Darwin" |
Member
There was a problem hiding this comment.
Is there a reason this is changed back?^^ RN it is equivalent to the windows one
Contributor
Author
There was a problem hiding this comment.
Funny thing is that short version didn't work :D And I was - compiler will optimize this either way :D
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
ntnn
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an internal mock OIDC so one can use the backend without an external Dex. Tests are still using dex so we cover that testing corner
Adds
kubebind dev createcommand to try to create "a development instance of kube-bind using two kind clusters" (preview). Will need follow-up to update released helm charts and imageskubectl bind dev create/deletewill require more iteration. Currently its very quick draft so we can test with as many people as we can do fix all the edge cases (and there is a lot as every workstation is different) so dont nit pick too much :DWhat Type of PR Is This?
/kind feature
Related Issue(s)
Fixes #349
Release Notes