Clean documentation & examples#377
Conversation
mjudeikis
changed the title
mjudeikis
force-pushed
the
cleanup.20251112
branch
from
62d6cc7 to
60f2ccf
Compare
| return nil | ||
| } | ||
|
|
||
| // Run executes the create command with plain output (no styling) |
There was a problem hiding this comment.
The comment says no styling but then it executes the WithColors method?^^
I also remember a pattern where the colours codes were used from a map and for uncoloured output the map was just empty.
There was a problem hiding this comment.
left-over. Originally added bubble tea + some fancy flows but kinda was overkill
| ``` | ||
|
|
||
| 2. Start kcp | ||
| 1. Start kcp |
There was a problem hiding this comment.
Unrelated to this change but after cloning none of the build commands are available. We need a make build step before bootstrapping kcp.
There was a problem hiding this comment.
as this is in dev-docs, I suspect some thinking from developers :D but yes
mjudeikis
force-pushed
the
cleanup.20251112
branch
from
60f2ccf to
431bfdb
Compare
mjudeikis
force-pushed
the
cleanup.20251112
branch
from
431bfdb to
bee933b
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| --version v1.16.2 \ | ||
| --set crds.enabled=true \ | ||
| cert-manager jetstack/cert-manager | ||
| kubectl bind dev create |
There was a problem hiding this comment.
In the kcp setup the locally built kubectl-bind is used, for the kind setup the user is expected to install the plugin.
It makes sense because the kcp setup also uses the run-kcp recipe, so the repo needs to be cloned, and the kind setup doesn't need anything outside of kind and the plugin. Then again in the developer docs we can expect people to have cloned the repo.
But should this be the same? Imho this is fine, just wanna put that up for discussion.
There was a problem hiding this comment.
For example, I have all my repos bin dirs in the PATH, so this kinda works. I think in general people should try, test and update :) we can use local binary reference too.
xmudrii
left a comment
xmudrii
left a comment
There was a problem hiding this comment.
Some very tiny nits, but high-level, this looks pretty solid. I'll try to give it a try sometime soon.
| app: cowboy | ||
| component: config No newline at end of file | ||
| namespaces: | ||
| - name: wild-west No newline at end of file |
| status: {} | ||
| app: sheriff | ||
| namespaces: | ||
| - name: sheriff-operations No newline at end of file |
| - name: mangodb | ||
| - name: foo No newline at end of file | ||
| - name: cowboys | ||
| - name: sheriffs No newline at end of file |
| ``` | ||
|
|
||
| 2. Start kcp | ||
| 1. Start kcp |
There was a problem hiding this comment.
This is pretty much what is in docs/content/developers/dev-environments.md - maybe we should just scrap what is mentioned here and point to those docs?
I'd prefer that over keeping copies (roughly) in sync.
There was a problem hiding this comment.
this will be fully refactored in follow-up pr (based on this). so bare with me for a bit :)
Add CLI styling to show output cleaner Signed-off-by: Mangirdas Judeikis <mangirdas@judeikis.lt> On-behalf-of: @SAP mangirdas.judeikis@sap.com
mjudeikis
force-pushed
the
cleanup.20251112
branch
from
bee933b to
39edbd2
Compare
3 participants
Summary
As per early users feedback - chanve
bind dev createoutput to be more readableStart consolidating our yaml files as they are all around the place
Remove some debug left-overs
What Type of PR Is This?
/kind cleanup
Related Issue(s)
Fixes #
Release Notes