Skip to content

fix cleaning up of rbac resource#378

Merged
xrstf merged 1 commit into
kbind-dev:mainfrom
olamilekan000:fix-rbac-not-being-cleaned-up
Nov 17, 2025
Merged

fix cleaning up of rbac resource#378
xrstf merged 1 commit into
kbind-dev:mainfrom
olamilekan000:fix-rbac-not-being-cleaned-up

Conversation

@olamilekan000

Copy link
Copy Markdown
Contributor

Summary

change fixes the cleanup of associated RBAC resources when an APIServiceExport
resource gets deleted

What Type of PR Is This?

/kind bug

Related Issue(s)

Fixes 329

Release Notes

Fix the cleaning up of RBAC resources when an APIServiceExport is deleted.

@olamilekan000 olamilekan000 requested a review from a team as a code owner November 12, 2025 12:44
@olamilekan000 olamilekan000 force-pushed the fix-rbac-not-being-cleaned-up branch 2 times, most recently from d02f526 to abd7364 Compare November 12, 2025 13:01
Comment thread backend/controllers/servicenamespace/servicenamespace_reconcile.go Outdated
Comment thread backend/controllers/servicenamespace/servicenamespace_reconcile.go Outdated
@olamilekan000 olamilekan000 force-pushed the fix-rbac-not-being-cleaned-up branch from abd7364 to d296ab0 Compare November 17, 2025 09:16
coderabbitai[bot]
coderabbitai Bot previously approved these changes Nov 17, 2025
@olamilekan000 olamilekan000 requested a review from xrstf November 17, 2025 09:16
Comment thread test-cleanup-export.yaml Outdated
Signed-off-by: olalekan odukoya <odukoyaonline@gmail.com>
@olamilekan000 olamilekan000 force-pushed the fix-rbac-not-being-cleaned-up branch from c4f2e1b to b728d46 Compare November 17, 2025 11:09

@xrstf xrstf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jo

@xrstf xrstf merged commit b91dabd into kbind-dev:main Nov 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add rbac cleanup logic

2 participants