Add GatewayAPI support & docs#395
Conversation
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
|
||
| Note !!! | ||
| To install production configuration, you will need to have OIDC provider. | ||
| If you interested just to try - check quickstart [quickstart]. |
There was a problem hiding this comment.
For more information, just check out the [quickstart guide].
| --values ./deploy/charts/backend/examples/values-local-development.yaml \ | ||
| kube-bind oci://ghcr.io/kube-bind/charts/backend --version 0.0.0-a50df39d7e4c71f7808f4209ec23f294c5ac8f86 | ||
| ``` | ||
| helm upgrade --install \ |
There was a problem hiding this comment.
Let's put --install on its own line, like every other flag 😁
| {{- if .Values.backend.cookieEncryptionKey }} | ||
| - --cookie-encryption-key={{ .Values.backend.cookieEncryptionKey }} | ||
| {{- end }} | ||
| {{- if .Values.backend.tls.enabled }} |
There was a problem hiding this comment.
So TLS is simply not supported anymore when using Ingresses? Can you explain your thinking in removing the flags from the chart, but keeping all the TLS code in the backend?
There was a problem hiding this comment.
GatewayAPI has TLSRoute, where we would need to do Passthrouth, but its experimental channel (https://gateway-api.sigs.k8s.io/concepts/api-overview/) so it is not installed by default :/ feels like everybody is doing TLS termination these days.
We could do TLS too, but this needs dragging in an experimental feature from the gateway api. And for now, I wanted to keep it simple.
There was a problem hiding this comment.
For now - lets keep it in the backend, if somebody would want to use it with this. You can still use it with ServiceType: Loadbalancer
There was a problem hiding this comment.
if somebody would want to use it with this. You can still use it with ServiceType: Loadbalancer
That was kind of why I asked. Can't we keep all the tls.enabled-guarded YAML intact, for those who want to use the LoadBalancer instead?
There was a problem hiding this comment.
make sense. will update
There was a problem hiding this comment.
reverted those changes
mjudeikis
dismissed stale reviews from cnvergence and coderabbitai[bot]
via
5639019
4 participants
Summary
Add docs how to deploy in "real world" and add GatewayAPI support vs old ingress.
Dropping TLS support as gateway api default pattern is to terminate.
What Type of PR Is This?
/kind cleanup
/kind feature
Related Issue(s)
Fixes #
Release Notes