Fix version flags in builds#402
Merged
Merged
Conversation
Contributor
Author
|
Strange panic... very strange |
cnvergence
reviewed
Nov 27, 2025
| go-version: v1.25.4 | ||
| - name: Delete non-semver tags | ||
| run: 'git tag -d $(git tag -l | grep -v "^v")' | ||
| - name: Set LDFLAGS |
Member
There was a problem hiding this comment.
can we also change the version in GIT_VERSION env to match version from release?
it is pinned to v0.0.0 atm eg. kube-bind-v0.0.0-a8dfe3c
Contributor
Author
There was a problem hiding this comment.
you want to use this for the image or smth else?
Currently this is the version:
v1.34.0+kube-bind-v0.5.1-58-g18cec9fd6a50c3
xrstf
approved these changes
Nov 27, 2025
xrstf
left a comment
xrstf
left a comment
Contributor
There was a problem hiding this comment.
under protest, because that change to the isolation strategy feels homeopathic at best
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix version string when building with goreleaser
What Type of PR Is This?
/kind bug
Related Issue(s)
Fixes #
Release Notes