Skip to content

Add ability to use secret for oidc secret#440

Closed
mjudeikis wants to merge 3 commits into
kbind-dev:mainfrom
mjudeikis:kcp.serving
Closed

Add ability to use secret for oidc secret#440
mjudeikis wants to merge 3 commits into
kbind-dev:mainfrom
mjudeikis:kcp.serving

Conversation

@mjudeikis

Copy link
Copy Markdown
Contributor

Summary

Add OIDC_CLIENT_SECRET into helm to overrride secret

What Type of PR Is This?

/kind feature

Related Issue(s)

Fixes #

Release Notes

Add OIDC_CLIENT_SECRET to configure oidc secret

@mjudeikis mjudeikis requested a review from a team as a code owner January 21, 2026 11:32
Comment thread backend/options/oidc.go
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jan 21, 2026
ntnn
ntnn previously approved these changes Jan 21, 2026

@ntnn ntnn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

cnvergence
cnvergence previously approved these changes Jan 21, 2026
@cnvergence cnvergence enabled auto-merge January 21, 2026 17:02
Signed-off-by: Mangirdas Judeikis <mangirdas@judeikis.lt>
On-behalf-of: @SAP mangirdas.judeikis@sap.com
@mjudeikis mjudeikis dismissed stale reviews from cnvergence, ntnn, and coderabbitai[bot] via 6cff2dc January 22, 2026 11:32
@mjudeikis

Copy link
Copy Markdown
Contributor Author

rebeaising pr here as kinda contaminated the branch #444

@mjudeikis mjudeikis closed this Jan 22, 2026
auto-merge was automatically disabled January 22, 2026 11:40

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants