-
Notifications
You must be signed in to change notification settings - Fork 37
add optional redis for backend storage #489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mjudeikis
merged 1 commit into
kbind-dev:main
from
olamilekan000:add-redis-storage-for-backend
Apr 7, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| /* | ||
| Copyright 2026 The Kube Bind Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package options | ||
|
|
||
| import ( | ||
| "github.com/spf13/pflag" | ||
|
|
||
| redisoptions "github.com/kube-bind/kube-bind/backend/options/session/redis" | ||
| ) | ||
|
|
||
| type Session struct { | ||
| Redis *redisoptions.Options | ||
| } | ||
|
|
||
| func NewSession() *Session { | ||
| return &Session{ | ||
| Redis: redisoptions.NewOptions(), | ||
| } | ||
| } | ||
|
|
||
| func (options *Session) AddFlags(fs *pflag.FlagSet) { | ||
| options.Redis.AddFlags(fs) | ||
| } | ||
|
|
||
| func (options *Session) Complete() error { | ||
| return options.Redis.Complete() | ||
| } | ||
|
|
||
| func (options *Session) Validate() error { | ||
| return options.Redis.Validate() | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| /* | ||
| Copyright 2026 The Kube Bind Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package redis | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "os" | ||
|
|
||
| "github.com/spf13/pflag" | ||
| ) | ||
|
|
||
| type Options struct { | ||
| Address string | ||
| Password string | ||
| } | ||
|
|
||
| func NewOptions() *Options { | ||
| return &Options{} | ||
| } | ||
|
|
||
| func (options *Options) AddFlags(fs *pflag.FlagSet) { | ||
| fs.StringVar(&options.Address, "redis-addr", options.Address, "The redis address (e.g. localhost:6379) to connect to if storing sessions in Redis. If empty, the in-memory provider is used.") | ||
| } | ||
|
|
||
| func (options *Options) Complete() error { | ||
| if pwd := os.Getenv("REDIS_PASSWORD"); pwd != "" { | ||
| options.Password = pwd | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func (options *Options) Validate() error { | ||
| if options.Password != "" && options.Address == "" { | ||
| return fmt.Errorf("redis-addr must be specified when using redis-password") | ||
| } | ||
| return nil | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| /* | ||
| Copyright 2026 The Kube Bind Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package memory | ||
|
|
||
| import ( | ||
| "context" | ||
| "errors" | ||
| "sync" | ||
| "time" | ||
|
|
||
| "github.com/kube-bind/kube-bind/backend/session" | ||
| ) | ||
|
|
||
| type pkceEntry struct { | ||
| verifier string | ||
| expiresAt time.Time | ||
| } | ||
|
|
||
| type Store struct { | ||
| lock sync.RWMutex | ||
| sessions map[string]*session.State | ||
| pkceVerifiers map[string]pkceEntry | ||
| } | ||
|
|
||
| func New() session.Store { | ||
| return &Store{ | ||
| sessions: make(map[string]*session.State), | ||
| pkceVerifiers: make(map[string]pkceEntry), | ||
| } | ||
| } | ||
|
|
||
| func (s *Store) Save(ctx context.Context, state *session.State) error { | ||
| s.lock.Lock() | ||
| defer s.lock.Unlock() | ||
| s.sessions[state.SessionID] = state | ||
| return nil | ||
| } | ||
|
|
||
| func (s *Store) Load(ctx context.Context, sessionID string) (*session.State, error) { | ||
| s.lock.RLock() | ||
| defer s.lock.RUnlock() | ||
| state, exists := s.sessions[sessionID] | ||
| if !exists { | ||
| return nil, session.ErrSessionNotFound | ||
| } | ||
| return state, nil | ||
| } | ||
|
|
||
| func (s *Store) Delete(ctx context.Context, sessionID string) error { | ||
| s.lock.Lock() | ||
| defer s.lock.Unlock() | ||
| delete(s.sessions, sessionID) | ||
| return nil | ||
| } | ||
|
|
||
| func (s *Store) SavePKCEVerifier(ctx context.Context, sessionID, verifier string) error { | ||
| if sessionID == "" || verifier == "" { | ||
| return errors.New("sessionID and verifier cannot be empty") | ||
| } | ||
| s.lock.Lock() | ||
| defer s.lock.Unlock() | ||
| s.pkceVerifiers[sessionID] = pkceEntry{ | ||
| verifier: verifier, | ||
| expiresAt: time.Now().Add(session.PKCEVerifierTTL), | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func (s *Store) LoadAndDeletePKCEVerifier(ctx context.Context, sessionID string) (string, error) { | ||
| if sessionID == "" { | ||
| return "", session.ErrPKCEVerifierNotFound | ||
| } | ||
| s.lock.Lock() | ||
| defer s.lock.Unlock() | ||
| entry, ok := s.pkceVerifiers[sessionID] | ||
| if !ok { | ||
| return "", session.ErrPKCEVerifierNotFound | ||
| } | ||
|
|
||
| delete(s.pkceVerifiers, sessionID) | ||
|
|
||
| if time.Now().After(entry.expiresAt) { | ||
| return "", session.ErrPKCEVerifierNotFound | ||
| } | ||
|
|
||
| return entry.verifier, nil | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.