contrib: add kcp schema serving#493
Merged
Merged
Conversation
Contributor
Author
|
Want to see what CI will tell for now |
Signed-off-by: Mangirdas Judeikis <mangirdas@judeikis.lt> On-behalf-of: SAP <mangirdas.judeikis@sap.com>
ad37e6b to
4bdb46a
Compare
Contributor
Author
|
@mjudeikis-bot review this please |
This comment was marked as resolved.
This comment was marked as resolved.
|
Review submitted — see the PR review above. One potential blocker flagged (the |
This comment was marked as resolved.
This comment was marked as resolved.
102fe7d to
1447333
Compare
Contributor
Author
|
@mjudeikis-bot, which of the code review questions are not yet addressed, as now it's a bit chaotic. Give clear bullet points and what needs to be changed and where. |
This comment was marked as resolved.
This comment was marked as resolved.
cnvergence
reviewed
Mar 16, 2026
| GOTESTSUM_VERSION := 1.8.1 | ||
| HELM_VERSION := 3.18.6 | ||
| KCP_VERSION := 0.29.0 | ||
| # unlreleased kcp version with vw code for schemas |
Member
There was a problem hiding this comment.
Suggested change
| # unlreleased kcp version with vw code for schemas | |
| # unreleased kcp version with vw code for schemas |
cnvergence
reviewed
Mar 16, 2026
Comment on lines
+39
to
+40
| # unlreleased kcp version with vw code for schemas | ||
| KCP_VERSION := 301a8f749e7b99a0c81f43b37aa5b5e5ff0fc0b4 |
cnvergence
reviewed
Mar 16, 2026
| ``` | ||
|
|
||
| 7. Get LogicalCluster: | ||
| 9. Get the LogicalCluster identity (needed for consumer binding): |
cnvergence
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables kube-bind to serve resources in a 3-tier kcp topology where the backend workspace has no
APIExportof its own — only anAPIBindingthat binds from an upstream provider workspace.Problem
Standard kube-bind + kcp is 2-tier:
:root:providerowns theAPIExport, consumer binds via kube-bind. This PR adds a 3-tier model:The backend has no APIExport — previously, this made it impossible to serve resources since kube-bind needs local APIServiceExportTemplate and APIResourceSchema copies.
What this adds
Two new kcp-specific controllers (only active with
--provider=kcp):apibindingtemplatecontroller — watches APIBinding objects; when Bound, auto-creates APIServiceExportTemplate objects (one per scope) derived from the bound resources; binding is owner so templates GC on removalapiresourceschemacontroller — watchesAPIServiceExportTemplate; copiesAPIResourceSchemadefinitions from the bound APIBinding into the backend workspace labeledkube-bind.io/exported=trueforServiceExportRequestdiscoveryBootstrap also gains
apibindings+subjectaccessreviewspermission claims required by the new controllers.Tests
kcp_3tier_test.go— two e2e tests covering cluster-scoped and namespaced resources through the fullprovider → backend → consumerchain.What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes #
Release Notes