fix: allow UI-only binding flow without CLI-provided cluster identity#495
Merged
Merged
Conversation
mjudeikis
reviewed
Mar 19, 2026
| showAlertModal('Missing cluster identity. Please ensure you have authenticated properly.', 'Binding Failed', 'error') | ||
| return | ||
| } | ||
| // In UI-only flow, clusterIdentity may be empty - the backend will derive |
Contributor
There was a problem hiding this comment.
The concern would be what if CLI does not provide it and we fail as it an error.
maybe we have dedicated UI identity: ui-identity so we handle it separatly so its always required?
Contributor
|
@cnvergence can we get this sorted? Would like to start getting these in for next release |
Member
Author
|
Right, let's split identities |
cnvergence
force-pushed
the
fix-ui-binding-cluster-id
branch
from
6ca10f2 to
64ef41b
Compare
mjudeikis
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed the hard block when clusterIdentity is empty. In UI-only flow (no CLI), there's no consumer_id or session_id in the URL, so we send an empty string and let the backend derive identity from the authenticated session.
What Type of PR Is This?
/kind bug
Related Issue(s)
Fixes #494
Release Notes