feat: check for correct response status code on create issue

Author: Art4

src/Redmine/Api/Issue.php

@@ -8,6 +8,7 @@
 use Redmine\Exception;
 use Redmine\Exception\SerializerException;
 use Redmine\Exception\UnexpectedResponseException;
+use Redmine\Future;
 use Redmine\Http\HttpClient;
 use Redmine\Http\HttpFactory;
 use Redmine\Serializer\JsonSerializer;
@@ -255,8 +256,12 @@ public function create(array $params = [])
 
         $body = $this->lastResponse->getContent();
 
-        if ($body === '') {
-            return $body;
+        if ($this->lastResponse->getStatusCode() !== 201) {
+            if (!Future::isForwardCompatibilityEnabled() && $body === '') {
+                return $body;
+            }
+
+            throw UnexpectedResponseException::create($this->lastResponse);
         }
 
         return new SimpleXMLElement($body);

tests/Unit/Api/Issue/CreateTest.php

@@ -6,6 +6,8 @@
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
 use Redmine\Api\Issue;
+use Redmine\Exception\UnexpectedResponseException;
+use Redmine\Future;
 use Redmine\Tests\Fixtures\AssertingHttpClient;
 use SimpleXMLElement;
 
@@ -232,7 +234,7 @@ public static function getCreateData(): array
         ];
     }
 
-    public function testCreateReturnsEmptyString(): void
+    public function testCreateWithIncorrectStatusCodeReturnsEmptyString(): void
     {
         $client = AssertingHttpClient::create(
             $this,
@@ -256,6 +258,35 @@ public function testCreateReturnsEmptyString(): void
         $this->assertSame('', $return);
     }
 
+    public function testCreateWithIncorrectStatusCodeThrowsException(): void
+    {
+        $client = AssertingHttpClient::create(
+            $this,
+            [
+                'POST',
+                '/issues.xml',
+                'application/xml',
+                '<?xml version="1.0" encoding="UTF-8"?><issue/>',
+                500,
+                '',
+                '',
+            ],
+        );
+
+        // Create the object under test
+        $api = Issue::fromHttpClient($client);
+
+        $this->expectException(UnexpectedResponseException::class);
+
+        try {
+            Future::enableForwardCompatibility();
+
+            $api->create([]);
+        } finally {
+            Future::disableForwardCompatibility();
+        }
+    }
+
     public function testCreateWithHttpClientRetrievesIssueStatusId(): void
     {
         $client = AssertingHttpClient::create(
@@ -274,7 +305,7 @@ public function testCreateWithHttpClientRetrievesIssueStatusId(): void
                 '/issues.xml',
                 'application/xml',
                 '<?xml version="1.0"?><issue><status_id>123</status_id></issue>',
-                200,
+                201,
                 'application/xml',
                 '<?xml version="1.0"?><issue></issue>',
             ],
@@ -311,7 +342,7 @@ public function testCreateWithHttpClientRetrievesProjectId(): void
                 '/issues.xml',
                 'application/xml',
                 '<?xml version="1.0"?><issue><project_id>3</project_id></issue>',
-                200,
+                201,
                 'application/xml',
                 '<?xml version="1.0"?><issue></issue>',
             ],
@@ -348,7 +379,7 @@ public function testCreateWithHttpClientRetrievesIssueCategoryId(): void
                 '/issues.xml',
                 'application/xml',
                 '<?xml version="1.0"?><issue><project_id>3</project_id><category_id>45</category_id></issue>',
-                200,
+                201,
                 'application/xml',
                 '<?xml version="1.0"?><issue></issue>',
             ],
@@ -385,7 +416,7 @@ public function testCreateWithHttpClientRetrievesTrackerId(): void
                 '/issues.xml',
                 'application/xml',
                 '<?xml version="1.0"?><issue><tracker_id>9</tracker_id></issue>',
-                200,
+                201,
                 'application/xml',
                 '<?xml version="1.0"?><issue></issue>',
             ],
@@ -422,7 +453,7 @@ public function testCreateWithHttpClientRetrievesUserId(): void
                 '/issues.xml',
                 'application/xml',
                 '<?xml version="1.0"?><issue><assigned_to_id>6</assigned_to_id><author_id>5</author_id></issue>',
-                200,
+                201,
                 'application/xml',
                 '<?xml version="1.0"?><issue></issue>',
             ],
@@ -508,7 +539,7 @@ public function testCreateWithClientCleansParameters(): void
                     <author_id>5</author_id>
                 </issue>
                 XML,
-                200,
+                201,
                 'application/xml',
                 '<?xml version="1.0"?><issue></issue>',
             ],

tests/Unit/Api/IssueTest.php

@@ -268,6 +268,9 @@ public function testCreateWithClientCleansParameters(): void
         $legacyClient->expects($this->exactly(1))
             ->method('getLastResponseContentType')
             ->willReturn('application/xml');
+        $legacyClient->expects($this->exactly(1))
+            ->method('getLastResponseStatusCode')
+            ->willReturn(201);
 
         // Create the object under test
         $api = new Issue($legacyClient);