test(desktop): fix test typing and remove unused symbols blocking build

Author: kccarlos

.agents/tasks/prd.json

@@ -541,11 +541,13 @@
         "All tests pass with `npm --workspace apps/desktop run test`"
       ],
       "attempts": 1,
-      "status": "in_progress",
-      "passes": false,
+      "status": "done",
+      "passes": true,
       "startedAt": "2026-02-22T14:56:12.699520+00:00",
-      "completedAt": null,
-      "updatedAt": "2026-02-22T14:56:12.699542+00:00"
+      "completedAt": "2026-02-22T15:04:34.879903+00:00",
+      "updatedAt": "2026-02-22T15:04:34.879903+00:00",
+      "skipped": false,
+      "notes": "Completion + verification gate passed."
     }
   ]
 }

apps/desktop/src/__tests__/theme.test.ts

@@ -1,4 +1,4 @@
-import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest'
+import { describe, it, expect, vi, beforeEach, afterEach, type MockInstance } from 'vitest'
 import { renderHook, act } from '@testing-library/react'
 import { useTheme } from '../hooks/useTheme'
 
@@ -27,7 +27,7 @@ function createMatchMediaMock(prefersDark: boolean) {
 // ── Tests ────────────────────────────────────────────────────────────────────
 
 describe('useTheme', () => {
-  let matchMediaSpy: ReturnType<typeof vi.spyOn>
+  let matchMediaSpy: MockInstance<Window['matchMedia']>
   let matchMediaMock: ReturnType<typeof createMatchMediaMock>
 
   beforeEach(() => {
@@ -37,7 +37,7 @@ describe('useTheme', () => {
 
     // Default: system prefers light
     matchMediaMock = createMatchMediaMock(false)
-    matchMediaSpy = vi.spyOn(window, 'matchMedia').mockReturnValue(matchMediaMock.mql as any)
+    matchMediaSpy = vi.spyOn(window, 'matchMedia').mockReturnValue(matchMediaMock.mql as unknown as MediaQueryList)
   })
 
   afterEach(() => {
@@ -57,7 +57,7 @@ describe('useTheme', () => {
 
   it('defaults to dark when system prefers dark', () => {
     matchMediaMock = createMatchMediaMock(true)
-    matchMediaSpy.mockReturnValue(matchMediaMock.mql as any)
+    matchMediaSpy.mockReturnValue(matchMediaMock.mql as unknown as MediaQueryList)
 
     const { result } = renderHook(() => useTheme())
 
@@ -126,7 +126,7 @@ describe('useTheme', () => {
   it('falls back to system preference when localStorage has no theme', () => {
     // Start with system-dark and no saved preference
     matchMediaMock = createMatchMediaMock(true)
-    matchMediaSpy.mockReturnValue(matchMediaMock.mql as any)
+    matchMediaSpy.mockReturnValue(matchMediaMock.mql as unknown as MediaQueryList)
 
     const { result } = renderHook(() => useTheme())
 
@@ -158,7 +158,7 @@ describe('useTheme', () => {
 
     // System prefers dark
     matchMediaMock = createMatchMediaMock(true)
-    matchMediaSpy.mockReturnValue(matchMediaMock.mql as any)
+    matchMediaSpy.mockReturnValue(matchMediaMock.mql as unknown as MediaQueryList)
 
     const { result } = renderHook(() => useTheme())
 

apps/desktop/src/__tests__/workspaceLifecycle.test.ts

@@ -13,7 +13,6 @@ import {
   setActiveWorkspace,
   upsertWorkspace,
   updateWorkspaceSession,
-  WORKSPACE_STORE_KEY,
   type WorkspaceSessionSnapshotInput,
   type WorkspaceStore,
 } from '../utils/workspaceStore'

apps/desktop/src/components/ErrorBanner.test.tsx

@@ -1,5 +1,5 @@
 import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest'
-import { render, screen, act, waitFor } from '@testing-library/react'
+import { render, screen, act } from '@testing-library/react'
 import userEvent from '@testing-library/user-event'
 import { useState, useEffect, useCallback } from 'react'
 import { ErrorBanner } from './ErrorBanner'

apps/desktop/src/components/SelectedFilesPanel.test.tsx

@@ -1,5 +1,5 @@
 import { describe, it, expect, vi, beforeEach } from 'vitest'
-import { render, screen, within } from '@testing-library/react'
+import { render, screen } from '@testing-library/react'
 import userEvent from '@testing-library/user-event'
 import { SelectedFilesPanel } from './SelectedFilesPanel'
 import type { FileDiffStatus } from '@gitcontext/core'

apps/desktop/src/hooks/useFileTree.test.ts

@@ -303,7 +303,7 @@ describe('useFileTree race condition prevention', () => {
         // Second (fresh) request — resolves immediately
         return Promise.resolve({ files: [{ path: 'fresh.ts', type: 'add' }] })
       }),
-      listFiles: vi.fn().mockImplementation((ref: string) => {
+      listFiles: vi.fn().mockImplementation((_ref: string) => {
         // For the second (fresh) request these resolve instantly.
         // For the first (stale) request, getDiff hasn't resolved yet so
         // listFiles will only be reached if getDiff resolves, and by then

apps/desktop/src/utils/diff.test.ts

@@ -88,7 +88,6 @@ describe('createUnifiedDiffForPath', () => {
     expect(result).toContain('+X')
     // With 0 context, surrounding unchanged lines should not appear as context
     const lines = result.split('\n')
-    const contextLines = lines.filter((l) => l.startsWith(' ') && l.trim().length > 0)
     // The only space-prefixed lines should be from the patch header, not content context
     // Filter out the header area
     const afterHunk = lines.slice(lines.findIndex((l) => l.startsWith('@@')))