feat(specs,tests): exception_test marker (ethereum#1436)

* feat(specs): Introduce/enforce `negative` marker

* feat(tests): Add marker to all invalid transaction/block tests

* changelog

* refactor(specs): Rename marker to `pytest.mark.exception_test`

* refactor(tests): Rename marker to `pytest.mark.exception_test`

* refactor(specs): Make `request` a `PrivateAttr`

* nit

* fix(specs): Review suggestions

Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>

---------

Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>

Author: marioevz

cancun/eip4844_blobs/test_blob_txs.py

@@ -424,6 +424,7 @@ def generate_invalid_tx_max_fee_per_blob_gas_tests(
             min_base_fee_per_blob_gas,  # tx max_blob_gas_cost is the minimum
             TransactionException.INSUFFICIENT_MAX_FEE_PER_BLOB_GAS,
             id="insufficient_max_fee_per_blob_gas",
+            marks=pytest.mark.exception_test,
         )
     )
     if (next_base_fee_per_blob_gas - min_base_fee_per_blob_gas) > 1:
@@ -436,6 +437,7 @@ def generate_invalid_tx_max_fee_per_blob_gas_tests(
                 - 1,  # tx max_blob_gas_cost is one less than the minimum
                 TransactionException.INSUFFICIENT_MAX_FEE_PER_BLOB_GAS,
                 id="insufficient_max_fee_per_blob_gas_one_less_than_next",
+                marks=pytest.mark.exception_test,
             )
         )
     if min_base_fee_per_blob_gas > 1:
@@ -446,6 +448,7 @@ def generate_invalid_tx_max_fee_per_blob_gas_tests(
                 min_base_fee_per_blob_gas - 1,  # tx max_blob_gas_cost is one less than the minimum
                 TransactionException.INSUFFICIENT_MAX_FEE_PER_BLOB_GAS,
                 id="insufficient_max_fee_per_blob_gas_one_less_than_min",
+                marks=pytest.mark.exception_test,
             )
         )
 
@@ -456,6 +459,7 @@ def generate_invalid_tx_max_fee_per_blob_gas_tests(
             0,  # tx max_blob_gas_cost is 0
             TransactionException.INSUFFICIENT_MAX_FEE_PER_BLOB_GAS,
             id="invalid_max_fee_per_blob_gas",
+            marks=pytest.mark.exception_test,
         )
     )
     return tests
@@ -533,6 +537,7 @@ def test_invalid_tx_max_fee_per_blob_gas_state(
     ],
     ids=["insufficient_max_fee_per_gas"],
 )
+@pytest.mark.exception_test
 @pytest.mark.valid_from("Cancun")
 def test_invalid_normal_gas(
     state_test: StateTestFiller,
@@ -572,6 +577,7 @@ def test_invalid_normal_gas(
     ],
     ids=[""],
 )
+@pytest.mark.exception_test
 @pytest.mark.valid_from("Cancun")
 def test_invalid_block_blob_count(
     blockchain_test: BlockchainTestFiller,
@@ -611,6 +617,7 @@ def test_invalid_block_blob_count(
 @pytest.mark.parametrize("tx_max_fee_per_blob_gas_multiplier", [1, 100, 10000])
 @pytest.mark.parametrize("account_balance_modifier", [-1], ids=["exact_balance_minus_1"])
 @pytest.mark.parametrize("tx_error", [TransactionException.INSUFFICIENT_ACCOUNT_FUNDS], ids=[""])
+@pytest.mark.exception_test
 @pytest.mark.valid_from("Cancun")
 def test_insufficient_balance_blob_tx(
     state_test: StateTestFiller,
@@ -831,6 +838,7 @@ def test_blob_gas_subtraction_tx(
 )
 @pytest.mark.parametrize("account_balance_modifier", [-1], ids=["exact_balance_minus_1"])
 @pytest.mark.parametrize("tx_error", [TransactionException.INSUFFICIENT_ACCOUNT_FUNDS], ids=[""])
+@pytest.mark.exception_test
 @pytest.mark.valid_from("Cancun")
 def test_insufficient_balance_blob_tx_combinations(
     blockchain_test: BlockchainTestFiller,
@@ -877,6 +885,7 @@ def generate_invalid_tx_blob_count_tests(
     "blobs_per_tx,tx_error",
     generate_invalid_tx_blob_count_tests,
 )
+@pytest.mark.exception_test
 @pytest.mark.valid_from("Cancun")
 def test_invalid_tx_blob_count(
     state_test: StateTestFiller,
@@ -921,6 +930,7 @@ def test_invalid_tx_blob_count(
 @pytest.mark.parametrize(
     "tx_error", [TransactionException.TYPE_3_TX_INVALID_BLOB_VERSIONED_HASH], ids=[""]
 )
+@pytest.mark.exception_test
 @pytest.mark.valid_from("Cancun")
 def test_invalid_blob_hash_versioning_single_tx(
     state_test: StateTestFiller,
@@ -979,6 +989,7 @@ def test_invalid_blob_hash_versioning_single_tx(
 @pytest.mark.parametrize(
     "tx_error", [TransactionException.TYPE_3_TX_INVALID_BLOB_VERSIONED_HASH], ids=[""]
 )
+@pytest.mark.exception_test
 @pytest.mark.valid_from("Cancun")
 def test_invalid_blob_hash_versioning_multiple_txs(
     blockchain_test: BlockchainTestFiller,
@@ -1005,6 +1016,7 @@ def test_invalid_blob_hash_versioning_multiple_txs(
 @pytest.mark.parametrize(
     "tx_gas", [500_000], ids=[""]
 )  # Increase gas to account for contract creation
+@pytest.mark.exception_test
 @pytest.mark.valid_from("Cancun")
 def test_invalid_blob_tx_contract_creation(
     blockchain_test: BlockchainTestFiller,
@@ -1347,6 +1359,7 @@ def test_blob_tx_attribute_gasprice_opcode(
     ],
     ids=["no_blob_tx", "one_blob_tx"],
 )
+@pytest.mark.exception_test
 @pytest.mark.valid_at_transition_to("Cancun")
 def test_blob_type_tx_pre_fork(
     state_test: StateTestFiller,

cancun/eip4844_blobs/test_blob_txs_full.py

@@ -293,6 +293,7 @@ def generate_full_blob_tests(
     "txs_blobs,txs_wrapped_blobs",
     generate_full_blob_tests,
 )
+@pytest.mark.exception_test
 @pytest.mark.valid_from("Cancun")
 def test_reject_valid_full_blob_in_block_rlp(
     blockchain_test: BlockchainTestFiller,

cancun/eip4844_blobs/test_excess_blob_gas.py

@@ -387,6 +387,7 @@ def test_correct_decreasing_blob_gas_costs(
     "parent_blobs",
     lambda fork: range(0, fork.max_blobs_per_block() + 1),
 )
+@pytest.mark.exception_test
 def test_invalid_zero_excess_blob_gas_in_header(
     blockchain_test: BlockchainTestFiller,
     env: Environment,
@@ -435,6 +436,7 @@ def all_invalid_blob_gas_used_combinations(fork: Fork) -> Iterator[Tuple[int, in
     all_invalid_blob_gas_used_combinations,
 )
 @pytest.mark.parametrize("parent_blobs", [0])
+@pytest.mark.exception_test
 def test_invalid_blob_gas_used_in_header(
     blockchain_test: BlockchainTestFiller,
     env: Environment,
@@ -479,6 +481,7 @@ def generate_invalid_excess_blob_gas_above_target_change_tests(fork: Fork) -> Li
     generate_invalid_excess_blob_gas_above_target_change_tests,
 )
 @pytest.mark.parametrize("new_blobs", [1])
+@pytest.mark.exception_test
 def test_invalid_excess_blob_gas_above_target_change(
     blockchain_test: BlockchainTestFiller,
     env: Environment,
@@ -523,6 +526,7 @@ def test_invalid_excess_blob_gas_above_target_change(
     "parent_excess_blobs", lambda fork: [1, fork.target_blobs_per_block()]
 )
 @pytest.mark.parametrize("new_blobs", [1])
+@pytest.mark.exception_test
 def test_invalid_static_excess_blob_gas(
     blockchain_test: BlockchainTestFiller,
     env: Environment,
@@ -564,6 +568,7 @@ def test_invalid_static_excess_blob_gas(
 )
 @pytest.mark.parametrize("parent_excess_blobs", [0])  # Start at 0
 @pytest.mark.parametrize("new_blobs", [1])
+@pytest.mark.exception_test
 def test_invalid_excess_blob_gas_target_blobs_increase_from_zero(
     blockchain_test: BlockchainTestFiller,
     env: Environment,
@@ -605,6 +610,7 @@ def test_invalid_excess_blob_gas_target_blobs_increase_from_zero(
 )
 @pytest.mark.parametrize("parent_excess_blobs", [0])  # Start at 0
 @pytest.mark.parametrize("new_blobs", [1])
+@pytest.mark.exception_test
 def test_invalid_static_excess_blob_gas_from_zero_on_blobs_above_target(
     blockchain_test: BlockchainTestFiller,
     env: Environment,
@@ -653,6 +659,7 @@ def test_invalid_static_excess_blob_gas_from_zero_on_blobs_above_target(
     ),
 )
 @pytest.mark.parametrize("new_blobs", [1])
+@pytest.mark.exception_test
 def test_invalid_excess_blob_gas_change(
     blockchain_test: BlockchainTestFiller,
     env: Environment,
@@ -704,6 +711,7 @@ def test_invalid_excess_blob_gas_change(
     "parent_excess_blobs",
     lambda fork: range(fork.target_blobs_per_block()),
 )
+@pytest.mark.exception_test
 def test_invalid_negative_excess_blob_gas(
     blockchain_test: BlockchainTestFiller,
     env: Environment,
@@ -753,6 +761,7 @@ def test_invalid_negative_excess_blob_gas(
     "parent_excess_blobs",
     lambda fork: [fork.target_blobs_per_block() + 1],
 )
+@pytest.mark.exception_test
 def test_invalid_non_multiple_excess_blob_gas(
     blockchain_test: BlockchainTestFiller,
     env: Environment,

cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py

@@ -213,6 +213,7 @@ def post(  # noqa: D103
         (True, True),
     ],
 )
+@pytest.mark.exception_test
 def test_invalid_pre_fork_block_with_blob_fields(
     blockchain_test: BlockchainTestFiller,
     env: Environment,
@@ -257,6 +258,7 @@ def test_invalid_pre_fork_block_with_blob_fields(
         (True, True),
     ],
 )
+@pytest.mark.exception_test
 def test_invalid_post_fork_block_without_blob_fields(
     blockchain_test: BlockchainTestFiller,
     env: Environment,

prague/eip6110_deposits/test_deposits.py

@@ -951,6 +951,7 @@ def test_deposit(
         ),
     ],
 )
+@pytest.mark.exception_test
 def test_deposit_negative(
     blockchain_test: BlockchainTestFiller,
     pre: Alloc,

prague/eip7002_el_triggerable_withdrawals/test_withdrawal_requests.py

@@ -679,6 +679,7 @@ def test_withdrawal_requests(
         ),
     ],
 )
+@pytest.mark.exception_test
 def test_withdrawal_requests_negative(
     pre: Alloc,
     fork: Fork,

prague/eip7251_consolidations/test_consolidations.py

@@ -730,6 +730,7 @@ def test_consolidation_requests(
         ),
     ],
 )
+@pytest.mark.exception_test
 def test_consolidation_requests_negative(
     pre: Alloc,
     fork: Fork,

prague/eip7623_increase_calldata_cost/test_transaction_validity.py

@@ -37,7 +37,7 @@
             # the data floor does not consume more gas than it should.
             pytest.param(1, id="extra_gas"),
             pytest.param(0, id="exact_gas"),
-            pytest.param(-1, id="insufficient_gas"),
+            pytest.param(-1, id="insufficient_gas", marks=pytest.mark.exception_test),
         ],
     ),
     pytest.mark.parametrize(

prague/eip7685_general_purpose_el_requests/test_multi_type_requests.py

@@ -604,6 +604,7 @@ def invalid_requests_block_combinations(fork: Fork) -> List[ParameterSet]:
     "requests,block_body_override_requests,exception",
     invalid_requests_block_combinations,
 )
+@pytest.mark.exception_test
 def test_invalid_deposit_withdrawal_consolidation_requests(
     blockchain_test: BlockchainTestFiller,
     pre: Alloc,
@@ -631,6 +632,7 @@ def test_invalid_deposit_withdrawal_consolidation_requests(
 )
 @pytest.mark.parametrize("correct_requests_hash_in_header", [True])
 @pytest.mark.blockchain_test_engine_only
+@pytest.mark.exception_test
 def test_invalid_deposit_withdrawal_consolidation_requests_engine(
     blockchain_test: BlockchainTestFiller,
     pre: Alloc,

prague/eip7702_set_code_tx/test_gas.py

@@ -894,7 +894,7 @@ def test_account_warming(
 @pytest.mark.parametrize(**gas_test_parameter_args(include_pre_authorized=False))
 @pytest.mark.parametrize(
     "valid",
-    [True, False],
+    [True, pytest.param(False, marks=pytest.mark.exception_test)],
 )
 def test_intrinsic_gas_cost(
     state_test: StateTestFiller,