🌱 rebase to k/k 1.35 (#75)

* rebase to k/k 1.35

* fix: add missing Apache 2.0 boilerplate headers

Files added in the k/k 1.35 rebase were missing the required
Apache 2.0 license boilerplate headers, causing verify-boilerplate
CI check to fail.

Signed-off-by: mjudeikis-bot <mjudeikis-bot@faros.sh>
Co-authored-by: Mangirdas Judeikis <mangirdas@judeikis.lt>

* fix: handle OverrideDefault errors to satisfy errcheck linter

Signed-off-by: mjudeikis-bot <mjudeikis-bot@faros.sh>
Co-authored-by: Mangirdas Judeikis <mangirdas@judeikis.lt>

* fix: replace broken pr-verifier Docker image with inline check

The pr-verifier workflow used gcr.io/kubebuilder/pr-verifier:v0.4.3
which is no longer available on Google Container Registry, causing
the 'verify PR contents' CI check to always fail with:

  manifest unknown: Failed to fetch "v0.4.3"

Replace with an equivalent inline shell step that checks the PR title
format directly, without requiring an external Docker image.

Signed-off-by: mjudeikis-bot <mjudeikis-bot@faros.sh>
Co-authored-by: Mangirdas Judeikis <mangirdas@judeikis.lt>

* chore: remove pr-verifier workflow

The gcr.io/kubebuilder/pr-verifier:v0.4.3 Docker image is no longer
available and the workflow has been breaking all PRs. Removing it entirely.

Signed-off-by: mjudeikis-bot <mjudeikis-bot@faros.sh>
Co-authored-by: Mangirdas Judeikis <mangirdas@judeikis.lt>

* fix: bump golangci-lint v1.54.2 → v1.64.8

v1.54.2 depends on go.tmz.dev/musttag which is no longer resolvable,
causing the lint CI job to fail at install time.

Signed-off-by: mjudeikis-bot <mjudeikis-bot@faros.sh>
Co-authored-by: Mangirdas Judeikis <mangirdas@judeikis.lt>

* fix: upgrade golangci-lint to v2 and fix all lint issues

- Bump golangci-lint v1.54.2 → v2.10.1 (v1.54.2 has dead dependency
  go.tmz.dev/musttag causing install failures)
- Add .golangci.yml with version: "2" config
- Fix revive lints: stutter (BatteriesList→List), receiver-naming,
  unused-parameter, blank-imports (add comments)
- Fix staticcheck QF1008: remove redundant embedded field selectors

Signed-off-by: mjudeikis-bot <mjudeikis-bot@faros.sh>
Co-authored-by: Mangirdas Judeikis <mangirdas@judeikis.lt>

* fix: fix golangci-lint v2 module path and resolve all lint/verify issues

- Fix golangci-lint install: v2 uses module path .../v2/cmd/golangci-lint
- Update .golangci.yml: disable blank-imports revive rule (conflicts with
  goimports import ordering)
- Strip inline comments from blank imports (goimports can't handle them)
- All checks pass: boilerplate, verify-imports, lint, build

Signed-off-by: mjudeikis-bot <mjudeikis-bot@faros.sh>
Co-authored-by: Mangirdas Judeikis <mangirdas@judeikis.lt>

* fix: bump staticcheck 2023.1 → 2025.1 for Go 1.25 support

staticcheck 2023.1 fails with 'invalid Go version: 1.25.0'.
2025.1 supports Go 1.25+.

Signed-off-by: mjudeikis-bot <mjudeikis-bot@faros.sh>
Co-authored-by: Mangirdas Judeikis <mangirdas@judeikis.lt>

* fix: switch golangci-lint install to binary download via uget.sh

Using 'go install' for golangci-lint v2 failed in prow because the
Go toolchain version requirement caused install failures. Switch to
downloading the pre-built binary directly from GitHub Releases,
matching how kcp manages golangci-lint.

Also removes the 'v' prefix from GOLANGCI_LINT_VER (uget.sh uses
version without 'v' in the download URL).

Signed-off-by: mjudeikis-bot <mjudeikis-bot@faros.sh>
Co-authored-by: Mangirdas Judeikis <mangirdas@judeikis.lt>

* fix: add KCP boilerplate to uget.sh and gitignore coverage.txt

- hack/uget.sh was missing the required Apache 2.0 boilerplate header
- coverage.txt was not gitignored, causing verify-imports to fail
  when make test was run before make verify-imports

Signed-off-by: mjudeikis-bot <mjudeikis-bot@faros.sh>
Co-authored-by: Mangirdas Judeikis <mangirdas@judeikis.lt>

* fix: make test depend on gotestsum so it installs before running

When USE_GOTESTSUM=1 (set by prow), make test uses the gotestsum binary.
Without it as a Makefile dependency it fails with 'command not found'.

Signed-off-by: mjudeikis-bot <mjudeikis-bot@faros.sh>
Co-authored-by: Mangirdas Judeikis <mangirdas@judeikis.lt>

* fix: bump gotestsum v1.8.1 → v1.13.0

v1.8.1 failed to install in prow with 'No such file or directory'.
v1.13.0 is the latest stable and installs correctly.

Signed-off-by: mjudeikis-bot <mjudeikis-bot@faros.sh>
Co-authored-by: Mangirdas Judeikis <mangirdas@judeikis.lt>

* fix: untrack coverage.txt and add to .gitignore

coverage.txt was tracked by git, so running make test would generate it
and cause verify-imports to fail (git diff sees the changed file).

Signed-off-by: mjudeikis-bot <mjudeikis-bot@faros.sh>
Co-authored-by: Mangirdas Judeikis <mangirdas@judeikis.lt>

---------

Signed-off-by: mjudeikis-bot <mjudeikis-bot@faros.sh>
Co-authored-by: Mangirdas Judeikis <mangirdas@judeikis.lt>
Co-authored-by: mjudeikis-bot <mjudeikis-bot@faros.sh>

Author: 3 people

.github/workflows/pr-verifier.yaml

@@ -4,3 +4,4 @@
 vendor
 hack/tools/*
 bin/gcp
+coverage.txt

.gitignore

@@ -0,0 +1,34 @@
+version: "2"
+run:
+  allow-parallel-runners: true
+linters:
+  default: none
+  enable:
+    - errcheck
+    - govet
+    - ineffassign
+    - staticcheck
+    - unused
+    - misspell
+    - gosec
+    - revive
+  settings:
+    revive:
+      rules:
+        - name: blank-imports
+          disabled: true
+        - name: unused-parameter
+        - name: receiver-naming
+        - name: error-strings
+  exclusions:
+    presets:
+      - comments
+      - common-false-positives
+      - std-error-handling
+    rules:
+      - linters:
+          - gosec
+        path: ".*_test\\.go"
+issues:
+  max-issues-per-linter: 0
+  max-same-issues: 0

.golangci.yml

@@ -7,7 +7,7 @@ presubmits:
       preset-goproxy: "true"
     spec:
       containers:
-        - image: ghcr.io/kcp-dev/infra/build:1.23.7-1
+        - image: ghcr.io/kcp-dev/infra/build:1.25.0-1
           command:
             - make
             - verify-boilerplate
@@ -25,7 +25,7 @@ presubmits:
       preset-goproxy: "true"
     spec:
       containers:
-        - image: ghcr.io/kcp-dev/infra/build:1.23.7-1
+        - image: ghcr.io/kcp-dev/infra/build:1.25.0-1
           command:
             - make
             - lint
@@ -64,7 +64,7 @@ presubmits:
       preset-goproxy: "true"
     spec:
       containers:
-        - image: ghcr.io/kcp-dev/infra/build:1.23.7-1
+        - image: ghcr.io/kcp-dev/infra/build:1.25.0-1
           command:
             - make
             - test

.prow.yaml

@@ -15,7 +15,7 @@
 # limitations under the License.
 
 # Build the binary
-FROM --platform=${BUILDPLATFORM} docker.io/golang:1.23.7 AS builder
+FROM --platform=${BUILDPLATFORM} docker.io/golang:1.25.0 AS builder
 WORKDIR /workspace
 
 # Install dependencies.

Dockerfile

@@ -44,15 +44,15 @@ OPENSHIFT_GOIMPORTS_BIN := openshift-goimports
 OPENSHIFT_GOIMPORTS := $(TOOLS_DIR)/$(OPENSHIFT_GOIMPORTS_BIN)-$(OPENSHIFT_GOIMPORTS_VER)
 export OPENSHIFT_GOIMPORTS # so hack scripts can use it
 
-GOLANGCI_LINT_VER := v1.54.2
+GOLANGCI_LINT_VER := 2.10.1
 GOLANGCI_LINT_BIN := golangci-lint
 GOLANGCI_LINT := $(TOOLS_GOBIN_DIR)/$(GOLANGCI_LINT_BIN)-$(GOLANGCI_LINT_VER)
 
-STATICCHECK_VER := 2023.1
+STATICCHECK_VER := 2025.1
 STATICCHECK_BIN := staticcheck
 STATICCHECK := $(TOOLS_GOBIN_DIR)/$(STATICCHECK_BIN)-$(STATICCHECK_VER)
 
-GOTESTSUM_VER := v1.8.1
+GOTESTSUM_VER := v1.13.0
 GOTESTSUM_BIN := gotestsum
 GOTESTSUM := $(abspath $(TOOLS_DIR))/$(GOTESTSUM_BIN)-$(GOTESTSUM_VER)
 
@@ -112,7 +112,10 @@ install: require-jq require-go require-git verify-go-versions ## Install the pro
 .PHONY: install
 
 $(GOLANGCI_LINT):
-	GOBIN=$(TOOLS_GOBIN_DIR) $(GO_INSTALL) github.com/golangci/golangci-lint/cmd/golangci-lint $(GOLANGCI_LINT_BIN) $(GOLANGCI_LINT_VER)
+	@UGET_DIRECTORY=$(TOOLS_GOBIN_DIR) UGET_VERSIONED_BINARIES=true hack/uget.sh \
+		https://github.com/golangci/golangci-lint/releases/download/v{VERSION}/golangci-lint-{VERSION}-{GOOS}-{GOARCH}.tar.gz \
+		$(GOLANGCI_LINT_BIN) \
+		$(GOLANGCI_LINT_VER)
 
 $(STATICCHECK):
 	GOBIN=$(TOOLS_GOBIN_DIR) $(GO_INSTALL) honnef.co/go/tools/cmd/staticcheck $(STATICCHECK_BIN) $(STATICCHECK_VER)
@@ -154,7 +157,7 @@ endif
 
 test: WHAT ?= ./...
 # We will need to move into the sub package, of sdk to run those tests.
-test: ## Run tests
+test: $(GOTESTSUM) ## Run tests
 	$(GO_TEST) -race $(COUNT_ARG) -coverprofile=coverage.txt -covermode=atomic $(TEST_ARGS) $$(go list "$(WHAT)")
 
 .PHONY: verify-imports