fix: fix golangci-lint v2 module path and resolve all lint/verify issues

- Fix golangci-lint install: v2 uses module path .../v2/cmd/golangci-lint
- Update .golangci.yml: disable blank-imports revive rule (conflicts with
  goimports import ordering)
- Strip inline comments from blank imports (goimports can't handle them)
- All checks pass: boilerplate, verify-imports, lint, build

Signed-off-by: mjudeikis-bot <mjudeikis-bot@faros.sh>
Co-authored-by: Mangirdas Judeikis <mangirdas@judeikis.lt>

Author: mjudeikis-bot

.golangci.yml

@@ -12,6 +12,14 @@ linters:
     - misspell
     - gosec
     - revive
+  settings:
+    revive:
+      rules:
+        - name: blank-imports
+          disabled: true
+        - name: unused-parameter
+        - name: receiver-naming
+        - name: error-strings
   exclusions:
     presets:
       - comments

Makefile

@@ -112,7 +112,7 @@ install: require-jq require-go require-git verify-go-versions ## Install the pro
 .PHONY: install
 
 $(GOLANGCI_LINT):
-	GOBIN=$(TOOLS_GOBIN_DIR) $(GO_INSTALL) github.com/golangci/golangci-lint/cmd/golangci-lint $(GOLANGCI_LINT_BIN) $(GOLANGCI_LINT_VER)
+	GOBIN=$(TOOLS_GOBIN_DIR) $(GO_INSTALL) github.com/golangci/golangci-lint/v2/cmd/golangci-lint $(GOLANGCI_LINT_BIN) $(GOLANGCI_LINT_VER)
 
 $(STATICCHECK):
 	GOBIN=$(TOOLS_GOBIN_DIR) $(GO_INSTALL) honnef.co/go/tools/cmd/staticcheck $(STATICCHECK_BIN) $(STATICCHECK_VER)

server/cmd/server.go

@@ -28,7 +28,7 @@ import (
 	apiextensionapiserver "k8s.io/apiextensions-apiserver/pkg/apiserver"
 	kerrors "k8s.io/apimachinery/pkg/util/errors"
 	utilruntime "k8s.io/apimachinery/pkg/util/runtime"
-	_ "k8s.io/apiserver/pkg/admission" // register admission plugins
+	_ "k8s.io/apiserver/pkg/admission"
 	genericapifilters "k8s.io/apiserver/pkg/endpoints/filters"
 	genericapiserver "k8s.io/apiserver/pkg/server"
 	utilfeature "k8s.io/apiserver/pkg/util/feature"
@@ -39,14 +39,14 @@ import (
 	"k8s.io/component-base/cli/globalflag"
 	"k8s.io/component-base/logs"
 	logsapi "k8s.io/component-base/logs/api/v1"
-	_ "k8s.io/component-base/metrics/prometheus/workqueue" // register workqueue metrics
+	_ "k8s.io/component-base/metrics/prometheus/workqueue"
 	"k8s.io/component-base/term"
 	"k8s.io/component-base/version"
 	"k8s.io/component-base/version/verflag"
 	"k8s.io/klog/v2"
 	aggregatorapiserver "k8s.io/kube-aggregator/pkg/apiserver"
 	controlplaneapiserver "k8s.io/kubernetes/pkg/controlplane/apiserver"
-	_ "k8s.io/kubernetes/pkg/features" // register feature gates
+	_ "k8s.io/kubernetes/pkg/features"
 
 	"github.com/kcp-dev/generic-controlplane/server/batteries"
 	"github.com/kcp-dev/generic-controlplane/server/cmd/help"