Skip to content

Commit 6823626

Browse files
mjudeikis-botmjudeikis
andcommitted
fix: handle OverrideDefault errors to satisfy errcheck linter
Signed-off-by: mjudeikis-bot <mjudeikis-bot@faros.sh> Co-authored-by: Mangirdas Judeikis <mangirdas@judeikis.lt>
1 parent 8b7791a commit 6823626

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

server/cmd/options/options.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,12 @@ func NewOptions(rootDir string) *Options {
8484
}
8585

8686
// Disable node related features to prevent the need for informers.
87-
utilfeature.DefaultMutableFeatureGate.OverrideDefault(features.ServiceAccountTokenNodeBindingValidation, false)
88-
utilfeature.DefaultMutableFeatureGate.OverrideDefault(features.ServiceAccountTokenNodeBinding, false)
87+
if err := utilfeature.DefaultMutableFeatureGate.OverrideDefault(features.ServiceAccountTokenNodeBindingValidation, false); err != nil {
88+
panic(err) // only fails on unknown feature gate, which is a programming error
89+
}
90+
if err := utilfeature.DefaultMutableFeatureGate.OverrideDefault(features.ServiceAccountTokenNodeBinding, false); err != nil {
91+
panic(err) // only fails on unknown feature gate, which is a programming error
92+
}
8993

9094
factory := func(factory informers.SharedInformerFactory) serviceaccount.ServiceAccountTokenGetter {
9195
return tokengetter.NewGetterFromClient(factory.Core().V1().Secrets().Lister(), factory.Core().V1().ServiceAccounts().Lister())

0 commit comments

Comments
 (0)