Skip to content

Fix stale conditions on delete#4005

Open
mjudeikis wants to merge 1 commit intokcp-dev:mainfrom
mjudeikis:apibinding.stale.condition
Open

Fix stale conditions on delete#4005
mjudeikis wants to merge 1 commit intokcp-dev:mainfrom
mjudeikis:apibinding.stale.condition

Conversation

@mjudeikis
Copy link
Copy Markdown
Contributor

@mjudeikis mjudeikis commented Apr 9, 2026

Summary

Prevents stale conditions on logicalcluster by making APIBinding delete to be last. Otherwise, we can get into a situation where apibinding is deleted before other resources, and you see a confusing condition

status:
  URL: https://localhost:8443/clusters/2q9x76rwu6vzssmp
  conditions:
  - lastTransitionTime: "2026-04-09T07:11:19Z"
    status: "True"
    type: APIBindingsReconciled
  - lastTransitionTime: "2026-04-09T07:07:49Z"
    message: 'Some resources are remaining: namespaces. has 2 resource instances'
    reason: SomeResourcesRemain
    severity: Info
    status: "False"
    type: WorkspaceContentDeleted

What Type of PR Is This?

Related Issue(s)

Fixes #

Release Notes

Fix stale condition on LogicalCluster by reordering the delete 

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Apr 9, 2026
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xrstf for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 9, 2026
@mjudeikis
Copy link
Copy Markdown
Contributor Author

/retest

Signed-off-by: Mangirdas Judeikis <mangirdas@judeikis.lt>
On-behalf-of: @SAP mangirdas.judeikis@sap.com
@mjudeikis mjudeikis force-pushed the apibinding.stale.condition branch from 9afe456 to 6c2aaf3 Compare April 9, 2026 10:07
@mjudeikis
Copy link
Copy Markdown
Contributor Author

/retest

@mjudeikis mjudeikis closed this Apr 9, 2026
@mjudeikis mjudeikis reopened this Apr 9, 2026
@mjudeikis
Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@mjudeikis
Copy link
Copy Markdown
Contributor Author

/retest

@kcp-ci-bot
Copy link
Copy Markdown
Contributor

@mjudeikis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kcp-test-integration 6c2aaf3 link true /test pull-kcp-test-integration
pull-kcp-test-e2e 6c2aaf3 link true /test pull-kcp-test-e2e
pull-kcp-test-e2e-shared 6c2aaf3 link true /test pull-kcp-test-e2e-shared
pull-kcp-test-e2e-sharded 6c2aaf3 link true /test pull-kcp-test-e2e-sharded
pull-kcp-test-e2e-multiple-runs 6c2aaf3 link true /test pull-kcp-test-e2e-multiple-runs

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gman0
Copy link
Copy Markdown
Contributor

gman0 commented Apr 13, 2026

There is an issue with the reconciler, needs fix in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants