Fix stale conditions on delete#4005
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
Signed-off-by: Mangirdas Judeikis <mangirdas@judeikis.lt> On-behalf-of: @SAP mangirdas.judeikis@sap.com
9afe456 to
6c2aaf3
Compare
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
@mjudeikis: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
There is an issue with the reconciler, needs fix in the code. |
Summary
Prevents stale conditions on logicalcluster by making APIBinding delete to be last. Otherwise, we can get into a situation where apibinding is deleted before other resources, and you see a confusing condition
What Type of PR Is This?
Related Issue(s)
Fixes #
Release Notes