Skip to content

Fix CachedResources flakes#4037

Open
mjudeikis wants to merge 4 commits intokcp-dev:mainfrom
mjudeikis:debug.cached.try4
Open

Fix CachedResources flakes#4037
mjudeikis wants to merge 4 commits intokcp-dev:mainfrom
mjudeikis:debug.cached.try4

Conversation

@mjudeikis
Copy link
Copy Markdown
Contributor

@mjudeikis mjudeikis commented Apr 16, 2026

Summary

In general, failures with cached resources were due to multiple tests using the same GK (not GVR), which caused shared informers to get confused. We were getting errors as the wrong schema was being picked up (kcp logs shows "missing namespace on schema" errors). To make it worse, other GVR running in parallel tests were in namespaces. So we had a namespace vs cluster scope clash.

I will create a follow-up issue as we have to move more of those to identity-based indexing as its an issue not only for cached resources but in general.

What Type of PR Is This?

/kind bug
/kind cleanup

Related Issue(s)

Fixes #

Release Notes

NONE

@kcp-ci-bot
Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 16, 2026
@mjudeikis
Copy link
Copy Markdown
Contributor Author

/test all

@kcp-ci-bot kcp-ci-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 16, 2026
@mjudeikis
Copy link
Copy Markdown
Contributor Author

/test all

@kcp-ci-bot kcp-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 16, 2026
@mjudeikis
Copy link
Copy Markdown
Contributor Author

/test all

@mjudeikis
Copy link
Copy Markdown
Contributor Author

/retest

@kcp-ci-bot kcp-ci-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 16, 2026
@mjudeikis mjudeikis changed the title [wip] cached resource flakes (3) [wip] fix CachedResources flakes Apr 16, 2026
@mjudeikis
Copy link
Copy Markdown
Contributor Author

/test all

Signed-off-by: Mangirdas Judeikis <mangirdas@judeikis.lt>
@mjudeikis mjudeikis marked this pull request as ready for review April 16, 2026 11:08
@mjudeikis mjudeikis changed the title [wip] fix CachedResources flakes Fix CachedResources flakes Apr 16, 2026
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2026
Comment thread pkg/reconciler/cache/cachedresources/cachedresources_reconcile_replication.go Outdated
@mjudeikis mjudeikis added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 16, 2026
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Apr 16, 2026
@mjudeikis mjudeikis added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 16, 2026
@mjudeikis
Copy link
Copy Markdown
Contributor Author

/test all

1 similar comment
@mjudeikis
Copy link
Copy Markdown
Contributor Author

/test all

@mjudeikis
Copy link
Copy Markdown
Contributor Author

/test all
passes consistently now

@xrstf
Copy link
Copy Markdown
Contributor

xrstf commented Apr 20, 2026

/approve
/lgtm

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2026
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2026
@gman0
Copy link
Copy Markdown
Contributor

gman0 commented Apr 20, 2026

@xrstf wait, i think this might need a closer look.

/hold

@kcp-ci-bot kcp-ci-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 20, 2026
@xrstf
Copy link
Copy Markdown
Contributor

xrstf commented Apr 20, 2026

/lgtm cancel

oops, sorry.

@kcp-ci-bot kcp-ci-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2026
@kcp-ci-bot kcp-ci-bot requested a review from xrstf April 20, 2026 11:51
@xrstf xrstf removed their assignment May 4, 2026
@gman0
Copy link
Copy Markdown
Contributor

gman0 commented May 5, 2026

Will check again today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants