Update run-with-prometheus to support local dev#4052
Update run-with-prometheus to support local dev#4052mjudeikis wants to merge 1 commit intokcp-dev:mainfrom
Conversation
kcp-ci-bot
added
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
kcp-ci-bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test all |
kcp-ci-bot
added
the
size/M
|
/test all |
kcp-ci-bot
removed
the
do-not-merge/work-in-progress
mjudeikis
changed the title
| if [ ! -x "${PROMETHEUS}" ]; then | ||
| echo "prometheus binary not found at ${PROMETHEUS}" >&2 | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Why is this necessary? What didn't work about old approach? make prometheus should never succeed if it fails to download Prometheus.
|
|
||
| .PHONY: prometheus | ||
| prometheus: $(PROMETHEUS) | ||
| @echo $(PROMETHEUS) |
There was a problem hiding this comment.
uget already prints the binary and only the binary path if UGET_PRINT_PATH is set. There's no need to echo something here. In fact, this breaks uget and forces you to have the tail -n1 in the prometheus script.
3 participants
Summary
So one can easily run prometheus when developing metrics or anything metrics related
What Type of PR Is This?
/kind cleanup
Related Issue(s)
Fixes #
Release Notes