Merge branch 'modify-to=double-quote' into 'master'

Enforce double quotes for strings

See merge request kdanmobile/shared-code-base/gems/json_requester!24

Author: 蔡耀賢

.gitlab-ci.yml

@@ -6,9 +6,22 @@ include:
 stages:
   - test
   - sast_upload
+  - lint
   - rspec
   - publish
 
+rubocop:
+  stage: lint
+  image: ruby:3.4.8
+  tags:
+    - arm64
+  script:
+    - bundle install
+    - bundle exec rubocop
+  rules:
+    - if: $CI_PIPELINE_SOURCE == "merge_request_event"
+    - if: $CI_COMMIT_BRANCH == "master"
+
 rspec:
   stage: rspec
   image: ruby:3.4.8
@@ -17,8 +30,9 @@ rspec:
   script:
     - bundle install
     - rspec spec
-  only:
-    - master
+  rules:
+    - if: $CI_PIPELINE_SOURCE == "merge_request_event"
+    - if: $CI_COMMIT_BRANCH == "master"
 
 to_gem:
   stage: publish

.rubocop.yml

@@ -15,6 +15,10 @@ Layout/LineLength:
 Style/Documentation:
   Enabled: false
 
+Style/StringLiterals:
+  Enabled: true
+  EnforcedStyle: double_quotes
+
 Metrics/MethodLength:
   Max: 25
 

CHANGELOG.md

@@ -1,3 +1,7 @@
+## [2.0.7] - 2026-03-30
+- Update RuboCop configuration to enforce double quotes for strings.
+- Add RuboCop lint stage to CI pipeline.
+
 ## [2.0.6] - 2026-03-30
 - Update mcp to version `0.9.2` for [Github GHSA-qvqr-5cv7-wh35](https://github.com/advisories/GHSA-qvqr-5cv7-wh35) security vulnerability warning.
 

Gemfile

@@ -1,18 +1,18 @@
 # frozen_string_literal: true
 
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 gemspec
 
 # Simple, but flexible HTTP client library, with support for multiple backends.
-gem 'faraday', '~> 2.14.1'
+gem "faraday", "~> 2.14.1"
 # Perform multipart-post requests using Faraday.
-gem 'faraday-multipart', '~> 1.2.0'
+gem "faraday-multipart", "~> 1.2.0"
 
 group :development, :test do
-  gem 'pry', '~> 0.16.0'
-  gem 'rspec', '~> 3.13.0'
-  gem 'rubocop', '~> 1.85.1'
-  gem 'rubocop-performance', '~> 1.26.1'
-  gem 'webmock', '~> 3.26', '>= 3.26.0'
+  gem "pry", "~> 0.16.0"
+  gem "rspec", "~> 3.13.0"
+  gem "rubocop", "~> 1.85.1"
+  gem "rubocop-performance", "~> 1.26.1"
+  gem "webmock", "~> 3.26", ">= 3.26.0"
 end

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    json_requester (2.0.6)
+    json_requester (2.0.7)
       faraday (~> 2.0, >= 2.0.1)
       faraday-multipart (~> 1.2.0)
 

VERSION.md

@@ -1 +1 @@
-2.0.6
+2.0.7

json_requester.gemspec

@@ -1,27 +1,27 @@
 # frozen_string_literal: true
 
 Gem::Specification.new do |s|
-  s.name        = 'json_requester'
-  s.version     = File.read('./VERSION.md')
+  s.name        = "json_requester"
+  s.version     = File.read("./VERSION.md")
   s.platform    = Gem::Platform::RUBY
-  s.summary     = 'Basic Wrapper of Faraday'
-  s.description = 'wrapper of faraday'
-  s.authors     = ['JiaRou Lee']
-  s.email       = 'laura34963@kdanmobile.com'
-  s.homepage    = 'https://github.com/kdan-mobile-software-ltd/json_requester'
-  s.license     = 'MIT'
+  s.summary     = "Basic Wrapper of Faraday"
+  s.description = "wrapper of faraday"
+  s.authors     = ["JiaRou Lee"]
+  s.email       = "laura34963@kdanmobile.com"
+  s.homepage    = "https://github.com/kdan-mobile-software-ltd/json_requester"
+  s.license     = "MIT"
   s.metadata    = {
-    'source_code_uri' => 'https://github.com/kdan-mobile-software-ltd/json_requester',
-    'changelog_uri' => 'https://github.com/kdan-mobile-software-ltd/json_requester/blob/master/CHANGELOG.md',
-    'rubygems_mfa_required' => 'true'
+    "source_code_uri" => "https://github.com/kdan-mobile-software-ltd/json_requester",
+    "changelog_uri" => "https://github.com/kdan-mobile-software-ltd/json_requester/blob/master/CHANGELOG.md",
+    "rubygems_mfa_required" => "true"
   }
 
   s.files            = `git ls-files -- lib/*`.split("\n")
-  s.extra_rdoc_files = ['README.md']
-  s.rdoc_options     = ['--charset=UTF-8']
-  s.require_path     = 'lib'
+  s.extra_rdoc_files = ["README.md"]
+  s.rdoc_options     = ["--charset=UTF-8"]
+  s.require_path     = "lib"
 
-  s.required_ruby_version = '>= 3.0.0'
-  s.add_dependency 'faraday', '~> 2.0', '>= 2.0.1'
-  s.add_dependency 'faraday-multipart', '~> 1.2.0'
+  s.required_ruby_version = ">= 3.0.0"
+  s.add_dependency "faraday", "~> 2.0", ">= 2.0.1"
+  s.add_dependency "faraday-multipart", "~> 1.2.0"
 end

lib/json_requester.rb

@@ -1,21 +1,21 @@
 # frozen_string_literal: true
 
-require 'faraday'
-require 'faraday/multipart'
-require 'json'
+require "faraday"
+require "faraday/multipart"
+require "json"
 
 class JsonRequester
   attr_reader :host, :conn
 
-  def initialize(host, multipart: false, ssl_verify: true, timeout: 60, user_agent: '')
+  def initialize(host, multipart: false, ssl_verify: true, timeout: 60, user_agent: "")
     @host = host
     @multipart = multipart
     @ssl_verify = ssl_verify
     @timeout = timeout
     @user_agent = user_agent.strip.to_s
   end
 
-  def http_send(http_method, path, params = {}, headers = {}, sort_params: true, need_response_header: false, content_type_charset: 'utf-8')
+  def http_send(http_method, path, params = {}, headers = {}, sort_params: true, need_response_header: false, content_type_charset: "utf-8")
     puts "send #{http_method} request to #{@host} with\npath: #{path}\nparams: #{params}\nheaders: #{headers}"
     if http_method == :get
       normal_send(http_method, path, params, headers, sort_params: sort_params, need_response_header: need_response_header)
@@ -36,12 +36,12 @@ def normal_send(http_method, path, params = {}, headers = {}, sort_params: true,
     error_response(e)
   end
 
-  def json_send(http_method, path, params = {}, headers = {}, sort_params: true, need_response_header: false, content_type_charset: 'utf-8')
+  def json_send(http_method, path, params = {}, headers = {}, sort_params: true, need_response_header: false, content_type_charset: "utf-8")
     conn = init_conn(sort_params: sort_params)
     res = conn.send(http_method) do |req|
       req.url path
       req.headers = headers if object_present?(headers)
-      req.headers['Content-Type'] = object_present?(content_type_charset) ? "application/json;charset=#{content_type_charset}" : 'application/json'
+      req.headers["Content-Type"] = object_present?(content_type_charset) ? "application/json;charset=#{content_type_charset}" : "application/json"
       req.body = params.to_json if object_present?(params)
     end
     process_response(res, need_response_header: need_response_header)
@@ -54,7 +54,7 @@ def form_send(http_method, path, params = {}, headers = {}, sort_params: true, n
     res = conn.send(http_method) do |req|
       req.url path
       req.headers = headers if object_present?(headers)
-      req.headers['Content-Type'] = 'application/x-www-form-urlencoded;charset=utf-8'
+      req.headers["Content-Type"] = "application/x-www-form-urlencoded;charset=utf-8"
       req.body = URI.encode_www_form(params) if object_present?(params)
     end
     process_response(res, need_response_header: need_response_header)
@@ -93,21 +93,21 @@ def init_conn(sort_params: true)
   end
 
   def process_response(response, need_response_header: false)
-    result = { 'status' => response.status }
+    result = { "status" => response.status }
     begin
       body = JSON.parse(response.body)
-      body = { 'body' => body } unless body.is_a?(Hash)
-      body['body_status'] = body.delete('status') unless body['status'].nil?
+      body = { "body" => body } unless body.is_a?(Hash)
+      body["body_status"] = body.delete("status") unless body["status"].nil?
     rescue StandardError
-      body = { 'body' => response.body }
+      body = { "body" => response.body }
     end
     result.merge!(body)
-    result['headers'] = response.headers.to_h if need_response_header
+    result["headers"] = response.headers.to_h if need_response_header
     result
   end
 
   def error_response(err)
-    { 'status' => 500, 'message' => "#{err.class.name}: #{err.message}" }
+    { "status" => 500, "message" => "#{err.class.name}: #{err.message}" }
   end
 
   def object_present?(object)