Merge pull request #186 from kdroidFilter/fix/playback-speed-range-and-dry

Lower min playback speed to 0.25x and extract constants

Author: kdroidFilter

mediaplayer/src/androidMain/kotlin/io/github/kdroidfilter/composemediaplayer/VideoPlayerState.android.kt

@@ -215,7 +215,7 @@ open class DefaultVideoPlayerState: VideoPlayerState {
     override var playbackSpeed: Float
         get() = _playbackSpeed
         set(value) {
-            _playbackSpeed = value.coerceIn(0.5f, 2.0f)
+            _playbackSpeed = value.coerceIn(VideoPlayerState.MIN_PLAYBACK_SPEED, VideoPlayerState.MAX_PLAYBACK_SPEED)
             exoPlayer?.let { player ->
                 player.playbackParameters = PlaybackParameters(_playbackSpeed)
             }

mediaplayer/src/commonMain/kotlin/io/github/kdroidfilter/composemediaplayer/VideoPlayerState.kt

@@ -53,6 +53,11 @@ interface VideoPlayerState {
     var loop: Boolean
     var playbackSpeed: Float
 
+    companion object {
+        const val MIN_PLAYBACK_SPEED = 0.25f
+        const val MAX_PLAYBACK_SPEED = 2.0f
+    }
+
     /**
      * Provides the audio level for the left channel as a percentage.
      */

mediaplayer/src/iosMain/kotlin/io/github/kdroidfilter/composemediaplayer/VideoPlayerState.ios.kt

@@ -76,7 +76,7 @@ open class DefaultVideoPlayerState: VideoPlayerState {
     override var playbackSpeed: Float
         get() = _playbackSpeed
         set(value) {
-            _playbackSpeed = value.coerceIn(0.5f, 2.0f)
+            _playbackSpeed = value.coerceIn(VideoPlayerState.MIN_PLAYBACK_SPEED, VideoPlayerState.MAX_PLAYBACK_SPEED)
             // Only update player rate if we are playing to avoid auto-play
             if (_isPlaying) {
                 player?.rate = _playbackSpeed

mediaplayer/src/jvmMain/kotlin/io/github/kdroidfilter/composemediaplayer/linux/LinuxVideoPlayerState.kt

@@ -141,7 +141,7 @@ class LinuxVideoPlayerState : VideoPlayerState {
     override var playbackSpeed: Float
         get() = _playbackSpeedState.value
         set(value) {
-            val newValue = value.coerceIn(0.5f, 2.0f)
+            val newValue = value.coerceIn(VideoPlayerState.MIN_PLAYBACK_SPEED, VideoPlayerState.MAX_PLAYBACK_SPEED)
             if (_playbackSpeedState.value != newValue) {
                 _playbackSpeedState.value = newValue
                 ioScope.launch { applyPlaybackSpeed() }

mediaplayer/src/jvmMain/kotlin/io/github/kdroidfilter/composemediaplayer/mac/MacVideoPlayerState.kt

@@ -147,7 +147,7 @@ class MacVideoPlayerState : VideoPlayerState {
     override var playbackSpeed: Float
         get() = _playbackSpeedState.value
         set(value) {
-            val newValue = value.coerceIn(0.5f, 2.0f)
+            val newValue = value.coerceIn(VideoPlayerState.MIN_PLAYBACK_SPEED, VideoPlayerState.MAX_PLAYBACK_SPEED)
             if (_playbackSpeedState.value != newValue) {
                 _playbackSpeedState.value = newValue
                 // Launch a coroutine to apply the playback speed if the native player is available.

mediaplayer/src/jvmMain/kotlin/io/github/kdroidfilter/composemediaplayer/windows/WindowsVideoPlayerState.kt

@@ -169,7 +169,7 @@ class WindowsVideoPlayerState : VideoPlayerState {
     override var playbackSpeed: Float
         get() = _playbackSpeed
         set(value) {
-            val newSpeed = value.coerceIn(0.5f, 2.0f)
+            val newSpeed = value.coerceIn(VideoPlayerState.MIN_PLAYBACK_SPEED, VideoPlayerState.MAX_PLAYBACK_SPEED)
             if (_playbackSpeed != newSpeed) {
                 _playbackSpeed = newSpeed
                 scope.launch {

mediaplayer/src/webMain/kotlin/io/github/kdroidfilter/composemediaplayer/VideoPlayerState.web.kt

@@ -104,7 +104,7 @@ open class DefaultVideoPlayerState: VideoPlayerState {
     override var playbackSpeed: Float
         get() = _playbackSpeed
         set(value) {
-            val newValue = value.coerceIn(0.5f, 2.0f)
+            val newValue = value.coerceIn(VideoPlayerState.MIN_PLAYBACK_SPEED, VideoPlayerState.MAX_PLAYBACK_SPEED)
             if (_playbackSpeed != newValue) {
                 _playbackSpeed = newValue
                 applyPlaybackSpeedWithThrottle(newValue)