Skip to content

Commit 6ba4940

Browse files
committed
Fix tests for VideoPlayerState interface
1 parent b8fcdaf commit 6ba4940

3 files changed

Lines changed: 22 additions & 21 deletions

File tree

mediaplayer/src/iosTest/kotlin/io/github/kdroidfilter/composemediaplayer/VideoPlayerStateTest.kt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ class VideoPlayerStateTest {
1616
*/
1717
@Test
1818
fun testCreateVideoPlayerState() {
19-
val playerState = VideoPlayerState()
19+
val playerState = createVideoPlayerState()
2020

2121
// Verify the player state is initialized correctly
2222
assertNotNull(playerState)
@@ -40,7 +40,7 @@ class VideoPlayerStateTest {
4040
*/
4141
@Test
4242
fun testVolumeControl() {
43-
val playerState = VideoPlayerState()
43+
val playerState = createVideoPlayerState()
4444

4545
// Test initial volume
4646
assertEquals(1f, playerState.volume)
@@ -65,7 +65,7 @@ class VideoPlayerStateTest {
6565
*/
6666
@Test
6767
fun testLoopSetting() {
68-
val playerState = VideoPlayerState()
68+
val playerState = createVideoPlayerState()
6969

7070
// Test initial loop setting
7171
assertFalse(playerState.loop)
@@ -86,7 +86,7 @@ class VideoPlayerStateTest {
8686
*/
8787
@Test
8888
fun testFullscreenToggle() {
89-
val playerState = VideoPlayerState()
89+
val playerState = createVideoPlayerState()
9090

9191
// Test initial fullscreen state
9292
assertFalse(playerState.isFullscreen)
@@ -108,7 +108,7 @@ class VideoPlayerStateTest {
108108
*/
109109
@Test
110110
fun testErrorHandling() {
111-
val playerState = VideoPlayerState()
111+
val playerState = createVideoPlayerState()
112112

113113
// Test opening a non-existent file
114114
playerState.openUri("non_existent_file.mp4")
@@ -125,7 +125,7 @@ class VideoPlayerStateTest {
125125
*/
126126
@Test
127127
fun testSubtitleFunctionality() {
128-
val playerState = VideoPlayerState()
128+
val playerState = createVideoPlayerState()
129129

130130
// Verify initial subtitle state
131131
assertFalse(playerState.subtitlesEnabled)

mediaplayer/src/jvmTest/kotlin/io/github/kdroidfilter/composemediaplayer/VideoPlayerStateTest.kt

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,10 @@ class VideoPlayerStateTest {
5757
return
5858
}
5959

60-
val playerState = VideoPlayerState()
60+
val playerState = createVideoPlayerState()
6161

6262
// Verify the player state is initialized correctly
6363
assertNotNull(playerState)
64-
assertNotNull(playerState.delegate)
6564
assertFalse(playerState.hasMedia)
6665
assertFalse(playerState.isPlaying)
6766
assertEquals(0f, playerState.sliderPos)
@@ -88,7 +87,7 @@ class VideoPlayerStateTest {
8887
return
8988
}
9089

91-
val playerState = VideoPlayerState()
90+
val playerState = createVideoPlayerState()
9291

9392
// Test initial volume
9493
assertEquals(1f, playerState.volume)
@@ -119,7 +118,7 @@ class VideoPlayerStateTest {
119118
return
120119
}
121120

122-
val playerState = VideoPlayerState()
121+
val playerState = createVideoPlayerState()
123122

124123
// Test initial loop setting
125124
assertFalse(playerState.loop)
@@ -146,7 +145,7 @@ class VideoPlayerStateTest {
146145
return
147146
}
148147

149-
val playerState = VideoPlayerState()
148+
val playerState = createVideoPlayerState()
150149

151150
// Test initial fullscreen state
152151
assertFalse(playerState.isFullscreen)
@@ -173,7 +172,7 @@ class VideoPlayerStateTest {
173172
return
174173
}
175174

176-
val playerState = VideoPlayerState()
175+
val playerState = createVideoPlayerState()
177176

178177
// Initially there should be no error
179178
assertEquals(null, playerState.error)

mediaplayer/src/wasmJsTest/kotlin/io/github/kdroidfilter/composemediaplayer/VideoPlayerStateTest.kt

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ class VideoPlayerStateTest {
1616
*/
1717
@Test
1818
fun testCreateVideoPlayerState() {
19-
val playerState = VideoPlayerState()
19+
val playerState = createVideoPlayerState()
2020

2121
// Verify the player state is initialized correctly
2222
assertNotNull(playerState)
@@ -40,7 +40,7 @@ class VideoPlayerStateTest {
4040
*/
4141
@Test
4242
fun testVolumeControl() {
43-
val playerState = VideoPlayerState()
43+
val playerState = createVideoPlayerState()
4444

4545
// Test initial volume
4646
assertEquals(1f, playerState.volume)
@@ -65,7 +65,7 @@ class VideoPlayerStateTest {
6565
*/
6666
@Test
6767
fun testLoopSetting() {
68-
val playerState = VideoPlayerState()
68+
val playerState = createVideoPlayerState()
6969

7070
// Test initial loop setting
7171
assertFalse(playerState.loop)
@@ -86,7 +86,7 @@ class VideoPlayerStateTest {
8686
*/
8787
@Test
8888
fun testFullscreenToggle() {
89-
val playerState = VideoPlayerState()
89+
val playerState = createVideoPlayerState()
9090

9191
// Test initial fullscreen state
9292
assertFalse(playerState.isFullscreen)
@@ -107,13 +107,14 @@ class VideoPlayerStateTest {
107107
*/
108108
@Test
109109
fun testErrorHandling() {
110-
val playerState = VideoPlayerState()
110+
val playerState = createVideoPlayerState()
111+
val webPlayerState = playerState as DefaultVideoPlayerState
111112

112113
// Initially there should be no error
113114
assertEquals(null, playerState.error)
114115

115116
// Test setting an error manually (since we can't easily trigger a real error in tests)
116-
playerState.setError(VideoPlayerError.NetworkError("Test error"))
117+
webPlayerState.setError(VideoPlayerError.NetworkError("Test error"))
117118

118119
// There should be an error now
119120
assertNotNull(playerState.error)
@@ -131,7 +132,7 @@ class VideoPlayerStateTest {
131132
*/
132133
@Test
133134
fun testSubtitleFunctionality() {
134-
val playerState = VideoPlayerState()
135+
val playerState = createVideoPlayerState()
135136

136137
// Initially subtitles should be disabled
137138
assertFalse(playerState.subtitlesEnabled)
@@ -168,15 +169,16 @@ class VideoPlayerStateTest {
168169
*/
169170
@Test
170171
fun testPositionUpdates() {
171-
val playerState = VideoPlayerState()
172+
val playerState = createVideoPlayerState()
173+
val webPlayerState = playerState as DefaultVideoPlayerState
172174

173175
// Test initial position
174176
assertEquals(0f, playerState.sliderPos)
175177
assertEquals("00:00", playerState.positionText)
176178
assertEquals("00:00", playerState.durationText)
177179

178180
// Test updating position manually with forceUpdate to bypass rate limiting
179-
playerState.updatePosition(30f, 120f, forceUpdate = true)
181+
webPlayerState.updatePosition(30f, 120f, forceUpdate = true)
180182

181183
// Verify position was updated
182184
assertEquals("00:30", playerState.positionText)

0 commit comments

Comments
 (0)