Commit 734b9e5
committed
Address review findings: instant replay after stop, end-event loss, dispose and resize races
- play() after stop() no longer stalls 10 s waiting for _hasMedia: reload
lastUri immediately when no media is loaded and no open is in flight.
- produceFrames(): re-read the duration before treating a consumed
didPlayToEnd event as a live-stream artifact, so a finite file whose
duration resolved late still fires onPlaybackEnded/loop.
- dispose(): log a warning when the pipeline-join or videoReaderMutex
timeouts expire instead of silently proceeding to nDisposePlayer.
- onResized(): a cancelled resize job no longer clears isResizing set by
the superseding call; the flag can also no longer stay stuck when the
job is cancelled during the debounce delay.1 parent 196cdbf commit 734b9e5
1 file changed
Lines changed: 33 additions & 5 deletions
File tree
- mediaplayer/src/jvmMain/kotlin/io/github/kdroidfilter/composemediaplayer/mac
Lines changed: 33 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
710 | 710 | | |
711 | 711 | | |
712 | 712 | | |
| 713 | + | |
| 714 | + | |
| 715 | + | |
| 716 | + | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
| 723 | + | |
713 | 724 | | |
714 | 725 | | |
715 | 726 | | |
| |||
995 | 1006 | | |
996 | 1007 | | |
997 | 1008 | | |
| 1009 | + | |
| 1010 | + | |
| 1011 | + | |
| 1012 | + | |
| 1013 | + | |
| 1014 | + | |
| 1015 | + | |
| 1016 | + | |
998 | 1017 | | |
999 | 1018 | | |
1000 | 1019 | | |
| |||
1266 | 1285 | | |
1267 | 1286 | | |
1268 | 1287 | | |
1269 | | - | |
1270 | 1288 | | |
| 1289 | + | |
1271 | 1290 | | |
1272 | 1291 | | |
1273 | | - | |
1274 | 1292 | | |
| 1293 | + | |
1275 | 1294 | | |
1276 | 1295 | | |
1277 | | - | |
| 1296 | + | |
| 1297 | + | |
| 1298 | + | |
1278 | 1299 | | |
1279 | 1300 | | |
1280 | 1301 | | |
| |||
1420 | 1441 | | |
1421 | 1442 | | |
1422 | 1443 | | |
1423 | | - | |
1424 | | - | |
| 1444 | + | |
| 1445 | + | |
| 1446 | + | |
| 1447 | + | |
| 1448 | + | |
| 1449 | + | |
| 1450 | + | |
| 1451 | + | |
| 1452 | + | |
1425 | 1453 | | |
1426 | 1454 | | |
1427 | 1455 | | |
| |||
0 commit comments