fix(mac,linux): convert VideoMetadata.duration to milliseconds#190
Merged
Conversation
nGetVideoDuration() returns seconds on macOS (CMTimeGetSeconds) and Linux (GStreamer duration / GST_SECOND). Multiply by 1000 before assigning to metadata.duration so the value matches the documented millisecond contract and aligns with iOS, Android, Windows, and Web. Fixes #153
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nGetVideoDuration()returns seconds on macOS (CMTimeGetSeconds) and Linux (gst_duration / GST_SECOND)metadata.durationwas assigned directly without converting to milliseconds, causing a unit mismatch with the documented API contractFixes #153
Test plan
VideoMetadata.durationreturns milliseconds on macOSVideoMetadata.durationreturns milliseconds on Linux