feat: add onPlaybackEnded callback to VideoPlayerState#191
Merged
Conversation
Add a nullable lambda callback that is invoked when playback reaches the end of media and loop is disabled. Implemented across all platforms: Android (ExoPlayer STATE_ENDED), iOS (AVPlayerItemDidPlayToEndTimeNotification), Windows (IsEOF), macOS/Linux (nConsumeDidPlayToEnd), and Web (HTML5 ended event). Also fix sliderPos and seekTo KDoc to document the correct 0-1000 range. Closes #152
…layerState classes Simplified code by removing redundant `.toInt()` calls for `rowBytes` and `path`, ensuring consistency and clarity across macOS and Linux platform implementations.
This was referenced Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onPlaybackEnded: (() -> Unit)?callback property toVideoPlayerStateinterface, invoked when playback reaches the end andloopisfalsesliderPos(was "0.0 to 1.0", corrected to "0.0 to 1000.0") andseekToTest plan
loop = falseand verifyonPlaybackEndedis calledloop = trueand verifyonPlaybackEndedis NOT calledonPlaybackEnded = nulldoes not cause crashesCloses #152