fix: use BlendMode.Src for video frame rendering#194
Merged
Conversation
Video frames from Windows Media Foundation have alpha bytes set to 0x00. With the default SrcOver blend mode, this causes the video to appear washed out or nearly invisible on light backgrounds, as pixels blend with the underlying surface color. Using BlendMode.Src ensures video pixels fully replace the destination, regardless of the alpha channel value. Fixes #98
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BlendMode.Srcinstead of defaultSrcOverwhen drawing video frames indrawScaledImage()BlendMode.Srcwrites pixels directly without alpha blending, fixing the rendering on all backgroundsFixes #98
Test plan
ContentScalemodes (Fit, Crop, FillWidth, etc.)