Skip to content

Refactor: Use an interface for dark mode detector#231

Open
amir1376 wants to merge 2 commits intokdroidFilter:mainfrom
amir1376:refactor/darkmode-detector
Open

Refactor: Use an interface for dark mode detector#231
amir1376 wants to merge 2 commits intokdroidFilter:mainfrom
amir1376:refactor/darkmode-detector

Conversation

@amir1376
Copy link
Copy Markdown

@amir1376 amir1376 commented May 8, 2026

🚀 Description

Provide a way to use the dark mode detector module in an un-opinionated way.

📄 Motivation and Context

At the moment there is no common way for non-compose or custom setups to use this module. maybe someone wants to check system dark mode in non-compose logic. or an app which has no dependency to compose at all.

🧪 How Has This Been Tested?

Unfortunately due to internet shutdown in Iran I was unable to compile the project. there are no big changes in this PR just some refactoring! so I think everything should be fine.

📦 Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

in order to help non-compose users can also benefit from this library as well - I suggest to separate this module into darkmode-detector-core and darkmode-detector-compose

@amir1376 amir1376 marked this pull request as ready for review May 8, 2026 08:03
@amir1376 amir1376 force-pushed the refactor/darkmode-detector branch 2 times, most recently from c6f6c2f to e0b5616 Compare May 8, 2026 08:36
@amir1376 amir1376 force-pushed the refactor/darkmode-detector branch from e0b5616 to 46cbe22 Compare May 8, 2026 08:38
@kdroidFilter
Copy link
Copy Markdown
Owner

kdroidFilter commented May 8, 2026

Hi ! Great thanks ! Can you update the doc mkdocs ? I will fix the linter

@amir1376
Copy link
Copy Markdown
Author

amir1376 commented May 8, 2026

Hi ! Great thanks ! Can you update the doc mkdocs ? I will fix the linter

Done.

@amir1376 amir1376 changed the title use an interface for dark mode detector Refactor: Use an interface for dark mode detector May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants