Refactor: Use an interface for dark mode detector#231
Open
amir1376 wants to merge 2 commits intokdroidFilter:mainfrom
Open
Refactor: Use an interface for dark mode detector#231amir1376 wants to merge 2 commits intokdroidFilter:mainfrom
amir1376 wants to merge 2 commits intokdroidFilter:mainfrom
Conversation
c6f6c2f to
e0b5616
Compare
e0b5616 to
46cbe22
Compare
Owner
|
Hi ! Great thanks ! Can you update the doc mkdocs ? I will fix the linter |
Author
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Description
Provide a way to use the dark mode detector module in an un-opinionated way.
📄 Motivation and Context
At the moment there is no common way for non-compose or custom setups to use this module. maybe someone wants to check system dark mode in non-compose logic. or an app which has no dependency to compose at all.
🧪 How Has This Been Tested?
Unfortunately due to internet shutdown in Iran I was unable to compile the project. there are no big changes in this PR just some refactoring! so I think everything should be fine.
📦 Types of changes
✅ Checklist
in order to help non-compose users can also benefit from this library as well - I suggest to separate this module into
darkmode-detector-coreanddarkmode-detector-compose