Add support for macOS 26+ layered icons#4
Merged
kdroidFilter merged 1 commit intomainfrom Feb 9, 2026
Merged
Conversation
Port of JetBrains/compose-multiplatform#5451. Adds a `layeredIconDir` DSL property that compiles a .icon directory into Assets.car via xcrun actool and embeds it in the .app bundle for both JVM and native Mac targets. Requires actool >= 26.0.
kdroidFilter
added a commit
that referenced
this pull request
Apr 19, 2026
X11 ICCCM compliance (#4/#5): - SetSelectionOwner now uses real server timestamp via PropertyNotify probe, not XCB_CURRENT_TIME (violates ICCCM §2.1). Added get_server_timestamp_locked() which fires a zero-byte ChangeProperty to trigger timestamp event. - TIMESTAMP replies now return g_own_ts (real value) instead of truncated 0. - Verified: xclip -o -t TIMESTAMP returns non-zero after our clipboard write. INCR cleanup (#3): - On INCR read timeout, delete property to unblock sender waiting for PropertyNotify=Delete (ICCCM compliant termination). Process lifecycle (#7): - Wayland: runCaptureBytes, runSilently, writeBytes now escalate to destroyForcibly() if SIGTERM doesn't terminate after 500ms grace. AccessBehavior mapping (#12): - Kotlin: explicit when() mapping (0→AlwaysAllow, 1→AskEveryTime, 2→AlwaysDeny) instead of ordinal/entries.getOrNull (fragile with future macOS versions). - ObjC: validate input 0..2 on set; return -1 if get() returns out-of-range. Documentation & robustness (#13, #1): - Clipboard.watch() doc: clarify poll interval is always honored; source of counter differs by backend (Mach IPC / XFixes / wl-paste). - Re-check isActive after slow availableFormats() to avoid emitting to cancelled flow. Added X11TimestampSmokeTest to verify real timestamps are used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
layeredIconDirDSL property tomacOS {}block for both JVM and native targets.icondirectories intoAssets.carviaxcrun actool(requires actool >= 26.0)Assets.carin the.appbundle and setsCFBundleIconNameinInfo.plistChanged files
PlatformSettings.kt— newlayeredIconDir: DirectoryPropertyMacAssetsTool.kt— new utility for actool compilation and version checkingAbstractJPackageTask.kt— layered icon support for JVM packagingAbstractNativeMacApplicationPackageAppDirTask.kt— layered icon support for native packagingInfoPlistBuilder.kt— addedCFBundleIconNameplist keyosUtils.kt— addedplutiltoMacUtilsconfigureJvmApplication.kt/configureNativeApplication.kt— DSL wiringREADME.md— documentation with usage examplesUsage
nativeDistributions { macOS { iconFile.set(project.file("icons/MyApp.icns")) // fallback layeredIconDir.set(project.file("icons/MyApp.icon")) // layered } }Test plan