fix: resolve linter issues in notification and model code

- Replace filepath.Join with filesystem.Join in notification mapper
- Add periods to end of type documentation comments
- Use require.NoError for error assertions in tests
- Add nolint:godox directives for legitimate TODO comments
- Remove unused deleteNotification function
- Fix gci formatting (struct field alignment, import ordering)
- Remove unnecessary trailing newline in manager

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: Matovidlo

internal/pkg/mapper/notification/local_load.go

@@ -2,7 +2,6 @@ package notification
 
 import (
 	"context"
-	"path/filepath"
 
 	"github.com/keboola/keboola-sdk-go/v2/pkg/keboola"
 
@@ -81,7 +80,7 @@ func (m *mapper) MapAfterLocalLoad(ctx context.Context, recipe *model.LocalLoadR
 			NotificationKey: notification.NotificationKey,
 		}
 		notificationManifest.SetParentPath(configDir)
-		notificationManifest.SetRelativePath(filepath.Join("notifications", entry.Name()))
+		notificationManifest.SetRelativePath(filesystem.Join("notifications", entry.Name()))
 
 		notificationState := &model.NotificationState{
 			NotificationManifest: notificationManifest,

internal/pkg/model/keys_test.go

@@ -4,6 +4,7 @@ import (
 	"testing"
 
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 )
 
 func TestNotificationKey_Kind(t *testing.T) {
@@ -122,7 +123,7 @@ func TestNotificationKey_ParentKey(t *testing.T) {
 		ID:          "456",
 	}
 	parent, err := key.ParentKey()
-	assert.NoError(t, err)
+	require.NoError(t, err)
 	assert.Equal(t, expected, parent)
 }
 

internal/pkg/model/manifest.go

@@ -77,8 +77,8 @@ type ConfigManifest struct {
 	RecordState `json:"-"`
 	ConfigKey
 	Paths
-	Relations     Relations                  `json:"relations,omitempty" validate:"dive"` // relations with other objects, for example variables definition
-	Metadata      *orderedmap.OrderedMap     `json:"metadata,omitempty"`
+	Relations     Relations               `json:"relations,omitempty" validate:"dive"` // relations with other objects, for example variables definition
+	Metadata      *orderedmap.OrderedMap  `json:"metadata,omitempty"`
 	Notifications []*NotificationManifest `json:"notifications,omitempty"`
 }
 

internal/pkg/model/object.go

@@ -365,7 +365,7 @@ func (m BranchMetadata) ToOrderedMap() *orderedmap.OrderedMap {
 	return res
 }
 
-// Branch represents a development branch in Keboola Storage
+// Branch represents a development branch in Keboola Storage.
 type Branch struct {
 	BranchKey
 	Name        string         `json:"name" validate:"required" diff:"true" metaFile:"true"`
@@ -476,7 +476,7 @@ func (m ConfigMetadata) InstanceID() string {
 	return m[instanceIDMetadataKey]
 }
 
-// Config represents a component configuration in Keboola Storage
+// Config represents a component configuration in Keboola Storage.
 type Config struct {
 	ConfigKey
 	Name           string                 `json:"name" validate:"required" diff:"true" metaFile:"true"`
@@ -531,7 +531,7 @@ func (c *ConfigWithRows) ToAPIObject(changeDescription string, changedFields Cha
 	return out, append(changedFields.Slice(), "changeDescription")
 }
 
-// ConfigRow represents a row within a component configuration
+// ConfigRow represents a row within a component configuration.
 type ConfigRow struct {
 	ConfigRowKey
 	Name        string                 `json:"name" diff:"true" metaFile:"true"`

internal/pkg/state/remote/manager.go

@@ -150,7 +150,6 @@ func (u *UnitOfWork) LoadAll(filter model.ObjectsFilter) {
 						return nil
 					}),
 				)
-
 			}
 
 			// Wait for sub-requests

internal/pkg/state/remote/notification.go

@@ -66,19 +66,12 @@ func (u *UnitOfWork) createNotificationRequest(notification *model.Notification)
 		req = req.WithFilters(notification.Filters)
 	}
 
-	// TODO: Handle expiration - NotificationExpiration doesn't expose fields
+	//nolint:godox // TODO: Handle expiration - NotificationExpiration doesn't expose fields
 	// Need SDK update to support passing expiration directly
 	_ = notification.ExpiresAt
 
-	// TODO: Add config reference once SDK supports it
+	//nolint:godox // TODO: Add config reference once SDK supports it
 	// req = req.WithConfig(notification.BranchID, notification.ComponentID, notification.ConfigID)
 
 	return req
 }
-
-// deleteNotification deletes a notification subscription via API.
-func (u *UnitOfWork) deleteNotification(key model.NotificationKey) error {
-	return u.keboolaProjectAPI.
-		DeleteNotificationSubscriptionRequest(keboola.NotificationSubscriptionKey{ID: key.ID}).
-		SendOrErr(u.ctx)
-}

internal/pkg/utils/testproject/project.go

@@ -32,18 +32,18 @@ import (
 
 type Project struct {
 	*testproject.Project
-	initStartedAt          time.Time
-	ctx                    context.Context
-	storageAPIToken        *keboola.Token
-	keboolaProjectAPI      *keboola.AuthorizedAPI
-	defaultBranch          *keboola.Branch
-	envs                   *env.Map
-	mapsLock               *sync.Mutex
-	stateFilePath          string
-	branchesByID           map[keboola.BranchID]*keboola.Branch
-	branchesByName         map[string]*keboola.Branch
-	notificationIDs        []keboola.NotificationSubscriptionID
-	logFn                  func(format string, a ...any)
+	initStartedAt     time.Time
+	ctx               context.Context
+	storageAPIToken   *keboola.Token
+	keboolaProjectAPI *keboola.AuthorizedAPI
+	defaultBranch     *keboola.Branch
+	envs              *env.Map
+	mapsLock          *sync.Mutex
+	stateFilePath     string
+	branchesByID      map[keboola.BranchID]*keboola.Branch
+	branchesByName    map[string]*keboola.Branch
+	notificationIDs   []keboola.NotificationSubscriptionID
+	logFn             func(format string, a ...any)
 }
 
 type UnlockFn func()