Commit c7909e7
fix(notifications): address claude[bot] review feedback
- Check filter operator (==) when matching subscription to parent config,
preventing false attribution for inequality filters on job.configuration.id
- Replace fragile strings.Contains("400") error detection with proper
errors.As(err, &NotificationError) + StatusCode() == 400 check
- Call ValidateNotificationFilters from MapAfterLocalLoad so invalid filter
field names are caught at load time instead of being dead code
- Sort suggestions in findSimilarFieldNames for deterministic output
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>1 parent f1ca8fa commit c7909e7
3 files changed
Lines changed: 8 additions & 5 deletions
File tree
- internal/pkg
- mapper/notification
- model
- state/remote
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
| 22 | + | |
21 | 23 | | |
22 | 24 | | |
23 | 25 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
| |||
110 | 111 | | |
111 | 112 | | |
112 | 113 | | |
| 114 | + | |
113 | 115 | | |
114 | 116 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | 5 | | |
7 | 6 | | |
8 | 7 | | |
| |||
36 | 35 | | |
37 | 36 | | |
38 | 37 | | |
39 | | - | |
40 | | - | |
| 38 | + | |
| 39 | + | |
41 | 40 | | |
42 | 41 | | |
43 | 42 | | |
| |||
143 | 142 | | |
144 | 143 | | |
145 | 144 | | |
146 | | - | |
147 | | - | |
| 145 | + | |
| 146 | + | |
148 | 147 | | |
149 | 148 | | |
150 | 149 | | |
| |||
0 commit comments