Skip to content

fix: miscellaneous build and test fixes #2534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Matovidlo merged 3 commits into from
Mar 2, 2026
Merged

fix: miscellaneous build and test fixes #2534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c453cb0
fix: replace undefined ptr.Ptr with new() in retry_test.go
Matovidlo Feb 28, 2026
50991fd
fix: set GOTOOLCHAIN=local and GONOSUMDB=* for xk6 Docker build
Matovidlo Feb 28, 2026
7dd0b89
fix: scope GONOSUMDB to k6 module paths only
Matovidlo Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions internal/pkg/service/stream/storage/model/retry_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,29 +250,29 @@ func TestRetryable_IncrementNonRetryableAttempt(t *testing.T) {
assert.Equal(t, Retryable{
RetryAttempt: 1,
RetryReason: "credential expired",
FirstFailedAt: ptr.Ptr(utctime.MustParse("2000-01-01T00:00:00.000Z")),
LastFailedAt: ptr.Ptr(utctime.MustParse("2000-01-01T00:00:00.000Z")),
RetryAfter: ptr.Ptr(utctime.MustParse("2000-01-01T02:00:00.000Z")), // +2 hours
FirstFailedAt: new(utctime.MustParse("2000-01-01T00:00:00.000Z")),
LastFailedAt: new(utctime.MustParse("2000-01-01T00:00:00.000Z")),
RetryAfter: new(utctime.MustParse("2000-01-01T02:00:00.000Z")), // +2 hours
Comment thread
Matovidlo marked this conversation as resolved.
Comment thread
Matovidlo marked this conversation as resolved.
}, v)

// Second attempt - FirstFailedAt should remain unchanged
v.IncrementNonRetryableAttempt(utctime.MustParse("2000-01-01T02:00:00.000Z").Time(), "credential expired", fixedInterval)
assert.Equal(t, Retryable{
RetryAttempt: 2,
RetryReason: "credential expired",
FirstFailedAt: ptr.Ptr(utctime.MustParse("2000-01-01T00:00:00.000Z")), // unchanged
LastFailedAt: ptr.Ptr(utctime.MustParse("2000-01-01T02:00:00.000Z")),
RetryAfter: ptr.Ptr(utctime.MustParse("2000-01-01T04:00:00.000Z")), // +2 hours (fixed)
FirstFailedAt: new(utctime.MustParse("2000-01-01T00:00:00.000Z")), // unchanged
LastFailedAt: new(utctime.MustParse("2000-01-01T02:00:00.000Z")),
RetryAfter: new(utctime.MustParse("2000-01-01T04:00:00.000Z")), // +2 hours (fixed)
Comment thread
Matovidlo marked this conversation as resolved.
}, v)

// Third attempt - still fixed interval
v.IncrementNonRetryableAttempt(utctime.MustParse("2000-01-01T04:00:00.000Z").Time(), "credential expired", fixedInterval)
assert.Equal(t, Retryable{
RetryAttempt: 3,
RetryReason: "credential expired",
FirstFailedAt: ptr.Ptr(utctime.MustParse("2000-01-01T00:00:00.000Z")), // unchanged
LastFailedAt: ptr.Ptr(utctime.MustParse("2000-01-01T04:00:00.000Z")),
RetryAfter: ptr.Ptr(utctime.MustParse("2000-01-01T06:00:00.000Z")), // +2 hours (fixed)
FirstFailedAt: new(utctime.MustParse("2000-01-01T00:00:00.000Z")), // unchanged
LastFailedAt: new(utctime.MustParse("2000-01-01T04:00:00.000Z")),
RetryAfter: new(utctime.MustParse("2000-01-01T06:00:00.000Z")), // +2 hours (fixed)
Comment thread
Matovidlo marked this conversation as resolved.
}, v)
}

Expand Down
5 changes: 5 additions & 0 deletions provisioning/stream/docker/k6/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ FROM golang:1.26-alpine AS build
# Install necessary packages for building
RUN apk add --no-cache git

# Prevent Go from attempting toolchain auto-switching (GOTOOLCHAIN=auto default in 1.21+)
# and skip GOSUM database lookups which can fail in Docker network environments
ENV GOTOOLCHAIN=local
ENV GONOSUMDB=go.k6.io,github.com/LeonAdato,github.com/domsolutions

# Install xk6
RUN go install go.k6.io/xk6/cmd/xk6@latest
Comment thread
Matovidlo marked this conversation as resolved.

Expand Down