docs: drop retired Templates feature docs from README#2631
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR unblocks CI by (1) excluding developers.keboola.com from the Markdown link checker due to Cloudflare bot protection returning 403 to non-browser clients, and (2) updating CLI E2E expected-state fixtures to match the Storage API’s evolved table definition shape (per-column definition object now present even for untyped columns).
Changes:
- Update the lint workflow’s lychee configuration to exclude
https://developers.keboola.com/.*from link checking. - Update CLI E2E
expected-state.jsonfixtures to include per-columndefinitionblocks for untyped tables.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/test-lint.yml |
Excludes developers.keboola.com from lychee link checking to prevent CI failures caused by Cloudflare 403 responses. |
test/cli/remote-table-upload/table-exist-same-csv-file-withtout-headers/expected-state.json |
Updates expected table-column snapshots to include per-column definition fields for untyped columns. |
test/cli/remote-table-upload/table-exist-same-csv-columns/expected-state.json |
Updates expected table-column snapshots to include per-column definition fields for untyped columns. |
test/cli/remote-table-upload/table-exist-same-csv-columns-diff-order/expected-state.json |
Updates expected table-column snapshots to include per-column definition fields for untyped columns. |
test/cli/remote-table-upload/table-exist-file-without-headers/expected-state.json |
Updates expected table-column snapshots to include per-column definition fields for untyped columns. |
test/cli/remote-table-upload/table-exist-columns-flag/expected-state.json |
Updates expected table-column snapshots to include per-column definition fields for untyped columns. |
test/cli/remote-table-upload/table-exist-columns-flag-file-without-headers/expected-state.json |
Updates expected table-column snapshots to include per-column definition fields for untyped columns. |
test/cli/remote-table-upload/table-exist-columns-flag-diff-order/expected-state.json |
Updates expected table-column snapshots to include per-column definition fields for untyped columns. |
test/cli/remote-table-upload/table-create-csv-columns/expected-state.json |
Updates expected table-column snapshots to include per-column definition fields for untyped columns. |
test/cli/remote-table-upload/table-create-columns-flag/expected-state.json |
Updates expected table-column snapshots to include per-column definition fields for untyped columns. |
test/cli/remote-table-upload/table-create-columns-flag-file-without-headers/expected-state.json |
Updates expected table-column snapshots to include per-column definition fields for untyped columns. |
test/cli/remote-table-unload/run-ok/expected-state.json |
Updates expected table-column snapshots to include per-column definition fields for untyped columns. |
test/cli/remote-table-import/import/expected-state.json |
Updates expected table-column snapshots to include per-column definition fields for untyped columns. |
test/cli/remote-table-download/with-where/expected-state.json |
Updates expected table-column snapshots to include per-column definition fields for untyped columns. |
test/cli/remote-table-download/with-header/expected-state.json |
Updates expected table-column snapshots to include per-column definition fields for untyped columns. |
test/cli/remote-table-download/with-header-columns/expected-state.json |
Updates expected table-column snapshots to include per-column definition fields for untyped columns. |
test/cli/remote-table-download/with-header-columns-where/expected-state.json |
Updates expected table-column snapshots to include per-column definition fields for untyped columns. |
test/cli/remote-table-download/with-header-columns-order/expected-state.json |
Updates expected table-column snapshots to include per-column definition fields for untyped columns. |
test/cli/remote-table-download/with-columns/expected-state.json |
Updates expected table-column snapshots to include per-column definition fields for untyped columns. |
test/cli/remote-table-download/run-ok/expected-state.json |
Updates expected table-column snapshots to include per-column definition fields for untyped columns. |
test/cli/remote-table-download/run-0-rows/expected-state.json |
Updates expected table-column snapshots to include per-column definition fields for untyped columns. |
test/cli/remote-create/table-interactive/expected-state.json |
Updates expected table-column snapshots to include per-column definition fields for untyped columns. |
test/cli/remote-create/table-columns-flag/expected-state.json |
Updates expected table-column snapshots to include per-column definition fields for untyped columns. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pepamartinec
force-pushed
the
pepa/fix-ci-table-def
branch
from
060e65d to
a19e2e0
Compare
pepamartinec
changed the title
pepamartinec
force-pushed
the
pepa/fix-ci-table-def
branch
from
a19e2e0 to
5dab544
Compare
pepamartinec
changed the title
The Templates API/CLI feature is being deprecated (Linear: deprecate-templates-api). Its user documentation was already removed from developers.keboola.com (AJDA-2897), and the dead links were cleaned from the repo docs in 767c357. Remove the remaining Templates references: the "Templates Service" section in README.md and the orphaned docs/templates/overview.md architecture doc. Code (Templates API + kbc template/local template commands) is left untouched and will be removed under a separate issue.
pepamartinec
force-pushed
the
pepa/fix-ci-table-def
branch
from
5dab544 to
311109d
Compare
pepamartinec
changed the title
keboola-pr-reviewer-bot
approved these changes
Jul 7, 2026
keboola-pr-reviewer-bot
left a comment
keboola-pr-reviewer-bot
left a comment
There was a problem hiding this comment.
Verdict: auto_approve (risk 1/5) · profile psgo
Auto-approve: markdown-only removal of retired Templates docs, no code touched.
janvanicek
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
The Templates API/CLI feature is being deprecated (Linear: deprecate-templates-api). Its user documentation was already removed from developers.keboola.com under AJDA-2897, and the resulting dead links were cleaned from this repo's docs in
767c35797.This PR removes the remaining Templates documentation references: the
#### Templates Servicesection inREADME.mdand the now-orphaneddocs/templates/overview.mdarchitecture doc. No code is touched — the Templates API service and thekbc template/kbc local templateCLI commands remain and will be removed under a separate issue.Plans for customer communication
None.
Impact analysis
No end-user impact. Documentation-only change.
Change type
Docs
Justification
Templates feature deprecation — remove its documentation footprint.
Deployment
Merge & automatic deploy.
Rollback plan
Revert of this PR.
Post release support plan
None.