Skip to content

Commit 93dbfda

Browse files
committed
KAB-46 flake8
1 parent bc4edbe commit 93dbfda

3 files changed

Lines changed: 37 additions & 43 deletions

File tree

kbcstorage/tables.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
from kbcstorage.tables_metadata import TablesMetadata
1515

1616

17-
1817
class Tables(Endpoint):
1918
"""
2019
Tables Endpoint

kbcstorage/tables_metadata.py

Lines changed: 29 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,7 @@
77
http://docs.keboola.apiary.io/#reference/metadata/table-metadata
88
"""
99
import json
10-
import tempfile
11-
import os
1210
from kbcstorage.base import Endpoint
13-
from kbcstorage.files import Files
14-
from kbcstorage.jobs import Jobs
1511

1612

1713
class TablesMetadata(Endpoint):
@@ -67,32 +63,32 @@ def delete(self, table_id, metadata_id):
6763
self._delete(url)
6864

6965
def create(self, table_id, provider, metadata, columns_metadata):
70-
"""
71-
Post metadata to a table.
72-
73-
Args:
74-
table_id (str): Table id
75-
provider (str): Provider of the metadata
76-
metadata (list): List of metadata dictionaries with 'key' and 'value'
77-
columns_metadata (dict): Dictionary with column metadata
78-
79-
Returns:
80-
response_body: The parsed json from the HTTP response.
81-
82-
Raises:
83-
requests.HTTPError: If the API request fails.
84-
"""
85-
if not isinstance(table_id, str) or table_id == '':
86-
raise ValueError("Invalid table_id '{}'.".format(table_id))
87-
88-
url = '{}/{}/metadata'.format(self.base_url, table_id)
89-
headers = {
90-
'Content-Type': 'application/json',
91-
'X-StorageApi-Token': self.token
92-
}
93-
data = {
94-
"provider": provider,
95-
"metadata": metadata,
96-
"columnsMetadata": columns_metadata
97-
}
98-
return self._post(url, data=json.dumps(data), headers=headers)
66+
"""
67+
Post metadata to a table.
68+
69+
Args:
70+
table_id (str): Table id
71+
provider (str): Provider of the metadata
72+
metadata (list): List of metadata dictionaries with 'key' and 'value'
73+
columns_metadata (dict): Dictionary with column metadata
74+
75+
Returns:
76+
response_body: The parsed json from the HTTP response.
77+
78+
Raises:
79+
requests.HTTPError: If the API request fails.
80+
"""
81+
if not isinstance(table_id, str) or table_id == '':
82+
raise ValueError("Invalid table_id '{}'.".format(table_id))
83+
84+
url = '{}/{}/metadata'.format(self.base_url, table_id)
85+
headers = {
86+
'Content-Type': 'application/json',
87+
'X-StorageApi-Token': self.token
88+
}
89+
data = {
90+
"provider": provider,
91+
"metadata": metadata,
92+
"columnsMetadata": columns_metadata
93+
}
94+
return self._post(url, data=json.dumps(data), headers=headers)

tests/functional/test_tables.py

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
from requests import exceptions
66
from kbcstorage.tables import Tables
77
from kbcstorage.buckets import Buckets
8-
from kbcstorage.tables_metadata import TablesMetadata
98
from tests.base_test_case import BaseTestCase
109

1110

@@ -345,13 +344,13 @@ def test_table_with_metadata(self):
345344
table_id=table_id,
346345
provider='test',
347346
metadata=[{
348-
'key' : 'test_table_with_metadata',
349-
'value' : 'success'
347+
'key': 'test_table_with_metadata',
348+
'value': 'success'
350349
}],
351350
columns_metadata={
352-
'col1' : [{
353-
'key' : 'test_column_with_metadata',
354-
'value' : 'success'
351+
'col1': [{
352+
'key': 'test_column_with_metadata',
353+
'value': 'success'
355354
}]
356355
})
357356

@@ -376,7 +375,7 @@ def test_table_with_metadata(self):
376375
self.assertIn('timestamp', table_info['columnMetadata']['col1'][0])
377376
self.assertEqual('success', table_info['columnMetadata']['col1'][0]['value'])
378377

379-
listedMetadata = self.tables.metadata.list(table_id=table_id);
378+
listedMetadata = self.tables.metadata.list(table_id=table_id)
380379

381380
with self.subTest("Test metadata key in list response"):
382381
self.assertEqual(1, len(listedMetadata))
@@ -386,6 +385,6 @@ def test_table_with_metadata(self):
386385

387386
self.tables.metadata.delete(table_id=table_id, metadata_id=listedMetadata[0]['id'])
388387

389-
listedMetadata = self.tables.metadata.list(table_id=table_id);
388+
listedMetadata = self.tables.metadata.list(table_id=table_id)
390389
with self.subTest('Test metadata can was deleted'):
391-
self.assertEqual(0, len(listedMetadata))
390+
self.assertEqual(0, len(listedMetadata))

0 commit comments

Comments
 (0)